Page MenuHomePhabricator
Differential D13569

[identity] Add exponential backoff to refresh_user_prekeys
ClosedPublic
Actions

Authored by bartek on Oct 2 2024, 1:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 9:17 PM
Unknown Object (File)
Wed, Dec 18, 9:34 AM
Unknown Object (File)
Wed, Dec 18, 9:34 AM
Unknown Object (File)
Wed, Dec 18, 9:33 AM
Unknown Object (File)
Wed, Dec 18, 9:33 AM
Unknown Object (File)
Sun, Dec 15, 2:49 PM
Unknown Object (File)
Sun, Dec 15, 2:01 AM
Unknown Object (File)
Sat, Dec 14, 10:42 PM
View All 33 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
Commits
rCOMM24a3b86ed9c5: [identity] Add exponential backoff to refresh_user_prekeys
Summary

Part of ENG-9427.
Added exponential backoff retry counter to RefreshUserPrekeys RPC

Depends on D13568

Test Plan

It's hard to do that on localstack, but I was able to reuse test plan from D13356 to block DB item with transactions and then confirmed that refresh_user_prekeys also retries.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Oct 2 2024, 1:10 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 2 2024, 1:10 AM
bartek added a child revision: D13570: [identity] Add exponential backoff to upload_one_time_keys.Oct 2 2024, 1:15 AM
Harbormaster completed remote builds in B32009: Diff 44813.Oct 2 2024, 1:25 AM
bartek published this revision for review.Oct 2 2024, 1:26 AM
will accepted this revision.Oct 2 2024, 12:23 PM
This revision is now accepted and ready to land.Oct 2 2024, 12:23 PM
varun accepted this revision.Oct 2 2024, 12:27 PM
varun added inline comments.
services/identity/src/database/device_list.rs
854 ↗(On Diff #44813)

i had to look at the code to jog my memory, but confirmed that sleep_and_retry respects the retry limit set by ExponentialBackoffConfig::default()

Closed by commit rCOMM24a3b86ed9c5: [identity] Add exponential backoff to refresh_user_prekeys (authored by bartek). · Explain WhyOct 3 2024, 1:10 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM24a3b86ed9c5: [identity] Add exponential backoff to refresh_user_prekeys.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
44 lines

Diff 44855

View Options

services/identity/src/database/device_list.rs

Loading...