Page MenuHomePhabricator
Differential D13571

[lib] Fix SQLite migrations
ClosedPublic
Actions

Authored by tomek on Oct 2 2024, 5:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 1:27 AM
Unknown Object (File)
Mon, Mar 3, 6:18 AM
Unknown Object (File)
Fri, Feb 28, 2:09 AM
Unknown Object (File)
Wed, Feb 26, 11:41 AM
Unknown Object (File)
Feb 18 2025, 4:01 PM
Unknown Object (File)
Feb 3 2025, 12:35 PM
Unknown Object (File)
Jan 30 2025, 2:51 PM
Unknown Object (File)
Jan 19 2025, 4:09 PM
View All 98 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
atul
Commits
rCOMM85789c85773e: [lib] Fix SQLite migrations
Summary

The migrations are broken because we weren't using the right shape of the specification. This diff fixes it and introduces necessary type checks.

https://linear.app/comm/issue/ENG-9467/redux-migrations-are-broken

Test Plan

Tested this by creating a new migration on the web where a new draft is created. Run the app, and reopened it. Checked if the SET_CLIENT_DB_STORE action contains the draft.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Oct 2 2024, 5:04 AM
tomek added inline comments.Oct 2 2024, 5:08 AM
native/redux/persist.js
1371 ↗(On Diff #44820)

Even adding this check doesn't force Flow to verify the migrations' types so we have to explicitly annotate each migration.

tomek updated this revision to Diff 44821.Oct 2 2024, 5:08 AM

Fix the import

Harbormaster completed remote builds in B32012: Diff 44821.Oct 2 2024, 5:25 AM
tomek requested review of this revision.Oct 2 2024, 5:25 AM
tomek edited the test plan for this revision. (Show Details)Oct 2 2024, 5:25 AM
ashoat accepted this revision.Oct 2 2024, 5:31 AM
ashoat added inline comments.
lib/utils/migration-utils.js
207 ↗(On Diff #44821)

I would name this MigrationFunction

210 ↗(On Diff #44821)

Why remove PersistedState here?

This revision is now accepted and ready to land.Oct 2 2024, 5:31 AM
Harbormaster completed remote builds in B32011: Diff 44820.Oct 2 2024, 5:34 AM
tomek added inline comments.Oct 2 2024, 8:51 AM
lib/utils/migration-utils.js
210 ↗(On Diff #44821)

PersistedState is an optional AppState. We were telling here that it can be used as an argument, but our migration functions were assuming that the state is mandatory. This issue was discovered by making the migration types explicit.

tomek updated this revision to Diff 44827.Oct 2 2024, 8:54 AM

Rename

Harbormaster completed remote builds in B32017: Diff 44827.Oct 2 2024, 9:11 AM
Closed by commit rCOMM85789c85773e: [lib] Fix SQLite migrations (authored by tomek). · Explain WhyOct 2 2024, 10:30 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM85789c85773e: [lib] Fix SQLite migrations.

Revision Contents
Changeset List

PathSize
lib/
shared/
redux/
29 lines
utils/
21 lines
native/
redux/
5 lines
76 lines
web/
redux/
65 lines

Diff 44831

View Options

lib/shared/redux/client-db-utils.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

lib/utils/migration-utils.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

native/redux/client-db-utils.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

native/redux/persist.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

web/redux/persist.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines