The migrations are broken because we weren't using the right shape of the specification. This diff fixes it and introduces necessary type checks.
https://linear.app/comm/issue/ENG-9467/redux-migrations-are-broken
Details
Details
- Reviewers
kamil ashoat atul - Commits
- rCOMM85789c85773e: [lib] Fix SQLite migrations
Tested this by creating a new migration on the web where a new draft is created. Run the app, and reopened it. Checked if the SET_CLIENT_DB_STORE action contains the draft.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/redux/persist.js | ||
|---|---|---|
| 1371 ↗ | (On Diff #44820) | Even adding this check doesn't force Flow to verify the migrations' types so we have to explicitly annotate each migration. |
| lib/utils/migration-utils.js | ||
|---|---|---|
| 210 ↗ | (On Diff #44821) | PersistedState is an optional AppState. We were telling here that it can be used as an argument, but our migration functions were assuming that the state is mandatory. This issue was discovered by making the migration types explicit. |