Page MenuHomePhabricator

[native] Fix reacting to robotext when sidebar is disabled
ClosedPublic

Authored by ashoat on Mon, Oct 14, 11:47 AM.
Tags
None
Referenced Files
F2982147: D13709.diff
Wed, Oct 16, 1:47 AM
F2974538: D13709.id45178.diff
Tue, Oct 15, 5:07 AM
F2974463: D13709.id45178.diff
Tue, Oct 15, 4:44 AM
F2974000: D13709.id.diff
Tue, Oct 15, 3:40 AM
F2973987: D13709.id.diff
Tue, Oct 15, 3:37 AM
Unknown Object (File)
Mon, Oct 14, 2:56 PM
Subscribers
None

Details

Summary

While working on the parent diffs, I noticed an issue where pressing on a robotext did nothing.

Turns out this is not a recent regression introduced by my changes, and is an issue that has been present since we refactored how the reaction options appear.

The issue is that we had a condition that exited if visibleEntryIDs.length === 0, but our reaction options aren't rendered via visibleEntryIDs.

This diff addresses it by adding && !canCreateReactionFromMessage to the check.

Depends on D13708

Test Plan

Confirm that on native, when I press on a robotext in a sidebar, I'm able to see options to react

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/chat/multimedia-message.react.js
249 ↗(On Diff #45178)

We don't need to use chatMessageItemEngagementTargetMessageInfo here, since we've already narrowed the type of props.item to ChatMultimediaMessageInfoItem

native/chat/text-message.react.js
181–183 ↗(On Diff #45178)

I removed this check because TextMessage.visibleEntryIDs never returns an empty array

This revision is now accepted and ready to land.Tue, Oct 15, 1:11 AM