Fix payloadSizeExceeded calculated incorrectly
ClosedPublic
Actions

Authored by angelika on Oct 15 2024, 5:05 AM.

Details

Reviewers

ashoat
kamil

Commits

rCOMM9f1950582fea: Fix payloadSizeExceeded calculated incorrectly

Summary

notificationSizeValidator returns true if notification size is less than maximum notification size (that is, the size is correct). However we set payloadSizeExceeded
to true if notificationSizeValidator returns true. That's obviously wrong and we need to negate it.
I think the bug was introduced in the first place by notificationSizeValidator being not obvious name. I renamed it in another diff (D13713).

Test Plan

Create a new chat
Verify that notification is verified correctly, that is payloadSizeExceeded is false.

Diff Detail

Repository

rCOMM Comm

Branch

@graszka22/ENG-9376

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Oct 15 2024, 5:05 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 15 2024, 5:05 AM

angelika added reviewers: ashoat, kamil.Oct 15 2024, 5:33 AM

angelika added a child revision: D13713: Rename notificationSizeValidator to isNotificationSizeValid.Oct 15 2024, 5:35 AM

angelika edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B32249: Diff 45194.Oct 15 2024, 5:36 AM

angelika requested review of this revision.Oct 15 2024, 5:36 AM

Nice work! It looks like Android has the same issue, but the variable is named slightly differently. If you agree with my assessment, can you fix it for Android too?