[lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus
Needs ReviewPublic
Actions

Authored by inka on Wed, Oct 16, 8:38 AM.

Details

Reviewers

tomek
kamil

Summary

issue: ENG-9633

Test Plan

Tested that when a user is missing a device list the accountMissingStatus is set. Checked that lastChecked is updated with next requests but missingSince stays the same.

checked that if non-empty a device list is returned by identity, accountMissingStatus is removed.

checked that further requests for the same user are stopped for 20s.

checked that if a user that has a recent lastChecked is picked in search (triggering onSelectUserFromSearch which calls useUsersSupportThickThreads) they are not queried for

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Wed, Oct 16, 8:38 AM

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Oct 16, 8:38 AM

inka added a parent revision: D13728: [lib] Mark missing users when fetching device lists.Wed, Oct 16, 8:39 AM

Harbormaster completed remote builds in B32272: Diff 45228.Wed, Oct 16, 9:02 AM

inka requested review of this revision.Wed, Oct 16, 9:02 AM

When I first proposed this approach, I had in mind that we would modify useGetAndUpdateDeviceListsForUsers:

We could modify useGetAndUpdateDeviceListsForUsers so that before we query for a user's device lists, we first check lastChecked, and skip the check if it's sufficiently recent.

Can you explain it your approach here a bit more? I'm curious: