Page MenuHomePhabricator
Differential D13405

[lib] Exclude users that don't support thick threads from results
ClosedPublic
Actions

Authored by tomek on Fri, Sep 20, 4:55 AM.
Tags
None
Referenced Files
F2842199: D13405.id44365.diff
Sun, Sep 29, 12:27 PM
F2840968: D13405.id44399.diff
Sun, Sep 29, 8:42 AM
F2839570: D13405.id44364.diff
Sun, Sep 29, 2:20 AM
Unknown Object (File)
Fri, Sep 27, 5:31 PM
Unknown Object (File)
Fri, Sep 27, 2:30 AM
Unknown Object (File)
Fri, Sep 27, 12:17 AM
Unknown Object (File)
Thu, Sep 26, 8:21 AM
Unknown Object (File)
Wed, Sep 25, 10:09 PM
View All 19 Files
Subscribers
ashoat

Details

Reviewers
kamil
will
Commits
rCOMMb74fa444e9fb: [lib] Exclude users that don't support thick threads from results
Summary

When a user can't be added to thick thread, they shouldn't be included in search results.

https://linear.app/comm/issue/ENG-9257/limit-chat-candidates-to-users-who-are-registered-with-identity

Depends on D13404

Test Plan

Checked that the user who don't support thick threads aren't shown in add member modals of thick threads.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Fri, Sep 20, 4:55 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 20, 4:55 AM
Harbormaster completed remote builds in B31733: Diff 44363.Fri, Sep 20, 5:12 AM
tomek requested review of this revision.Fri, Sep 20, 5:12 AM
ashoat added inline comments.Fri, Sep 20, 6:05 AM
lib/shared/search-utils.js
166 ↗(On Diff #44363)

In what cases is threadType not set here?

ashoat mentioned this in D13404: [lib] Create a thin thread when some users don't support thick threads.Fri, Sep 20, 6:06 AM
tomek added inline comments.Fri, Sep 20, 6:33 AM
lib/shared/search-utils.js
166 ↗(On Diff #44363)

This happens in chat-thread-composer.react.js and message-list-container.react.js where we don't know what the resulting thread type would be. In these cases, we shouldn't filter out users who don't have CSAT because we're determining the thread thickness later, based on the presence of the CSAT.

ashoat added inline comments.Fri, Sep 20, 6:43 AM
lib/shared/search-utils.js
166 ↗(On Diff #44363)

Thanks for explaining!

kamil accepted this revision.Fri, Sep 20, 6:58 AM
This revision is now accepted and ready to land.Fri, Sep 20, 6:58 AM
Closed by commit rCOMMb74fa444e9fb: [lib] Exclude users that don't support thick threads from results (authored by tomek). · Explain WhyFri, Sep 20, 8:41 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMb74fa444e9fb: [lib] Exclude users that don't support thick threads from results.

Revision Contents
Changeset List

PathSize
lib/
shared/
48 lines
7 lines
12 lines
native/
chat/
2 lines
2 lines
settings/
2 lines
web/
chat/
3 lines
settings/
relationship/
4 lines

Diff 44398

View Options

lib/shared/search-utils.js

Loading...
View Options

lib/shared/thread-actions-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/chat/compose-subchannel.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/chat/settings/add-users-modal.react.js

Loading...
View Options

web/chat/chat-thread-composer.react.js

Loading...
View Options

web/settings/relationship/add-users-utils.js

Loading...