[lib] Create a thin thread when some users don't support thick threads
ClosedPublic
Actions

Authored by tomek on Sep 20 2024, 4:44 AM.

Details

Reviewers

kamil
will

Commits

rCOMM2d42431b4c86: [lib] Create a thin thread when some users don't support thick threads

Summary

Check if all the users support thick threads and chose thread type accordingly.

https://linear.app/comm/issue/ENG-9257/limit-chat-candidates-to-users-who-are-registered-with-identity

Test Plan

On both native and web checked if the correct thread type is created, when sending text message, depending on the presence of members in AuxUserStore

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 20 2024, 4:44 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 4:44 AM

tomek added a child revision: D13405: [lib] Exclude users that don't support thick threads from results.Sep 20 2024, 4:55 AM

tomek added inline comments.Sep 20 2024, 4:55 AM

lib/selectors/thread-selectors.js
465–468 ↗	(On Diff #44362)	A thin thread could be created from a thick pending thread. The opposite isn't possible now, but for completeness, I'm not making this assumption here.

Harbormaster completed remote builds in B31732: Diff 44362.Sep 20 2024, 5:01 AM

tomek requested review of this revision.Sep 20 2024, 5:01 AM

ashoat added inline comments.Sep 20 2024, 5:56 AM

lib/shared/thread-actions-utils.js
140–142 ↗	(On Diff #44362)	I'll need this check as part of ENG-9330: Fork membership actions for thick threads. Assuming your diff is landed first, I'll try to make a note to factor it out into a utility function before landing