Check if all the users support thick threads and chose thread type accordingly.
Details
Details
On both native and web checked if the correct thread type is created, when sending text message, depending on the presence of members in AuxUserStore
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/selectors/thread-selectors.js | ||
|---|---|---|
| 465–468 | A thin thread could be created from a thick pending thread. The opposite isn't possible now, but for completeness, I'm not making this assumption here. | |
| lib/shared/thread-actions-utils.js | ||
|---|---|---|
| 140–142 | I'll need this check as part of ENG-9330: Fork membership actions for thick threads. Assuming your diff is landed first, I'll try to make a note to factor it out into a utility function before landing | |
| lib/selectors/thread-selectors.js | ||
|---|---|---|
| 465–468 | Worth adding code comment | |