Page MenuHomePhabricator

[lib] Exclude users that don't support thick threads from results
ClosedPublic

Authored by tomek on Sep 20 2024, 4:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:42 AM
Unknown Object (File)
Fri, Nov 8, 1:42 AM
Unknown Object (File)
Fri, Nov 8, 1:33 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Fri, Oct 18, 3:25 PM
Unknown Object (File)
Oct 12 2024, 9:03 AM
Unknown Object (File)
Oct 9 2024, 5:50 PM
Unknown Object (File)
Oct 7 2024, 6:49 PM
Subscribers

Details

Summary

When a user can't be added to thick thread, they shouldn't be included in search results.

https://linear.app/comm/issue/ENG-9257/limit-chat-candidates-to-users-who-are-registered-with-identity

Depends on D13404

Test Plan

Checked that the user who don't support thick threads aren't shown in add member modals of thick threads.

Diff Detail

Repository
rCOMM Comm
Branch
improvements2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Sep 20 2024, 5:12 AM
lib/shared/search-utils.js
166

In what cases is threadType not set here?

lib/shared/search-utils.js
166

This happens in chat-thread-composer.react.js and message-list-container.react.js where we don't know what the resulting thread type would be. In these cases, we shouldn't filter out users who don't have CSAT because we're determining the thread thickness later, based on the presence of the CSAT.

lib/shared/search-utils.js
166

Thanks for explaining!

This revision is now accepted and ready to land.Sep 20 2024, 6:58 AM