[lib] Use setLocalFID when updating local FID to match identity
ClosedPublic
Actions

Authored by ashoat on Oct 16 2024, 8:56 PM.

Details

Reviewers

will

Commits

rCOMMfbaa1e172e5f: [lib] Use setLocalFID when updating local FID to match identity

Summary

unlinkFID was wrong here because:

We don't need to contact identity to update an FID we got from identity
If the FID is non-null, we end up erasing it

Instead we should just update the local FID to match identity.

Depends on D13737

Test Plan

Careful analysis of this case (it happens when identity FID doesn't match local FID)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 16 2024, 8:56 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 16 2024, 8:56 PM

Harbormaster completed remote builds in B32283: Diff 45240.Oct 16 2024, 9:38 PM

ashoat requested review of this revision.Oct 16 2024, 9:38 PM

will accepted this revision.Oct 16 2024, 10:36 PM

This revision is now accepted and ready to land.Oct 16 2024, 10:36 PM

Closed by commit rCOMMfbaa1e172e5f: [lib] Use setLocalFID when updating local FID to match identity (authored by ashoat). · Explain WhyOct 17 2024, 6:58 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfbaa1e172e5f: [lib] Use setLocalFID when updating local FID to match identity.

Revision Contents
Changeset List

Path

Size

lib/

components/

farcaster-data-handler.react.js

2 lines

Diff 45240

View Options

lib/components/farcaster-data-handler.react.js

[lib] Use setLocalFID when updating local FID to match identityClosedPublicActions