[landing] Remove invalid size prop in TeamProfile
ClosedPublic
Actions

Authored by ashoat on Oct 28 2024, 12:52 PM.

Details

Reviewers

varun
will

Commits

rCOMM5b1ddea9fbe3: [landing] Remove invalid size prop in TeamProfile

Summary

Noticed this error in the console while working on this page:

Removed the property and nothing changed visually, so I figured we should remove it to get rid of the error, since it seems to be an invalid prop anyways.

Depends on D13798

Test Plan

Confirmed the error was gone
Confirmed the icons stayed the same size

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 28 2024, 12:52 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 28 2024, 12:52 PM

ashoat edited the summary of this revision. (Show Details)Oct 28 2024, 12:53 PM

Harbormaster completed remote builds in B32388: Diff 45405.Oct 28 2024, 1:10 PM

ashoat requested review of this revision.Oct 28 2024, 1:10 PM

varun accepted this revision.Oct 28 2024, 1:17 PM

This revision is now accepted and ready to land.Oct 28 2024, 1:17 PM

Closed by commit rCOMM5b1ddea9fbe3: [landing] Remove invalid size prop in TeamProfile (authored by ashoat). · Explain WhyOct 28 2024, 1:19 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5b1ddea9fbe3: [landing] Remove invalid size prop in TeamProfile.

Revision Contents
Changeset List

Path

Size

landing/

team-profile.react.js

8 lines

Diff 45410

View Options

landing/team-profile.react.js

[landing] Remove invalid size prop in TeamProfileClosedPublicActions