[landing] Bump GitHub link to the front
ClosedPublic
Actions

Authored by ashoat on Oct 28 2024, 12:39 PM.

Details

Reviewers

varun
will

Commits

rCOMM92660e349d10: [landing] Bump GitHub link to the front

Summary

Given we have such a strong focus on being open source, I figure bumping the GitHub link earlier makes sense.

Depends on D13797

Test Plan

desktop

mobile

Screenshot 2024-10-28 at 3.42.14 PM.png (586×374 px, 25 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 28 2024, 12:39 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 28 2024, 12:39 PM

This diff looks complicated because Phabricator is highlighting it wrong. I just reordered the elements, moving the GitHub one before the Farcaster and Twitter ones

ashoat edited the test plan for this revision. (Show Details)Oct 28 2024, 12:42 PM

ashoat added a child revision: D13799: [landing] Remove invalid size prop in TeamProfile.Oct 28 2024, 12:52 PM

Harbormaster completed remote builds in B32387: Diff 45404.Oct 28 2024, 12:56 PM

ashoat requested review of this revision.Oct 28 2024, 12:56 PM

will accepted this revision.Oct 28 2024, 1:05 PM

This revision is now accepted and ready to land.Oct 28 2024, 1:05 PM

Closed by commit rCOMM92660e349d10: [landing] Bump GitHub link to the front (authored by ashoat). · Explain WhyOct 28 2024, 1:19 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM92660e349d10: [landing] Bump GitHub link to the front.

Revision Contents
Changeset List

Path

Size

landing/

header.react.js

32 lines

mobile-nav.react.js

12 lines

Diff 45409

View Options

landing/header.react.js