Page MenuHomePhabricator
Differential D13798

[landing] Bump GitHub link to the front
ClosedPublic
Actions

Authored by ashoat on Oct 28 2024, 12:39 PM.
Tags
None
Referenced Files
F6209676: D13798.diff
Wed, Apr 23, 11:05 PM
Unknown Object (File)
Fri, Apr 4, 2:16 AM
Unknown Object (File)
Wed, Apr 2, 4:34 PM
Unknown Object (File)
Wed, Apr 2, 6:42 AM
Unknown Object (File)
Tue, Apr 1, 6:41 AM
Unknown Object (File)
Mar 3 2025, 6:25 AM
Unknown Object (File)
Mar 3 2025, 6:25 AM
Unknown Object (File)
Feb 28 2025, 3:45 AM
View All 53 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMM92660e349d10: [landing] Bump GitHub link to the front
Summary

Given we have such a strong focus on being open source, I figure bumping the GitHub link earlier makes sense.

Depends on D13797

Test Plan

desktop

Screenshot 2024-10-28 at 3.42.02 PM.png (132×582 px, 8 KB)

mobile

Screenshot 2024-10-28 at 3.42.14 PM.png (586×374 px, 25 KB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/landing
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 28 2024, 12:39 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 28 2024, 12:39 PM
ashoat added a comment.Oct 28 2024, 12:41 PM

This diff looks complicated because Phabricator is highlighting it wrong. I just reordered the elements, moving the GitHub one before the Farcaster and Twitter ones

ashoat edited the test plan for this revision. (Show Details)Oct 28 2024, 12:42 PM
ashoat added a child revision: D13799: [landing] Remove invalid size prop in TeamProfile.Oct 28 2024, 12:52 PM
Harbormaster completed remote builds in B32387: Diff 45404.Oct 28 2024, 12:56 PM
ashoat requested review of this revision.Oct 28 2024, 12:56 PM
will accepted this revision.Oct 28 2024, 1:05 PM
This revision is now accepted and ready to land.Oct 28 2024, 1:05 PM
Closed by commit rCOMM92660e349d10: [landing] Bump GitHub link to the front (authored by ashoat). · Explain WhyOct 28 2024, 1:19 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM92660e349d10: [landing] Bump GitHub link to the front.

Revision Contents
Changeset List

PathSize
landing/
32 lines
12 lines

Diff 45404

View Options

landing/header.react.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });
View Options

landing/mobile-nav.react.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });