[lib] Tighten utils type to contain only thick threads
ClosedPublic
Actions

Authored by tomek on Oct 31 2024, 7:59 AM.

Details

Reviewers

kamil
angelika

Commits

rCOMM580b6451cbab: [lib] Tighten utils type to contain only thick threads

Summary

It is inconvenient to have the assertions in a lot of places - the issue would become a lot worse after the rest of the stack.

This diff introduces a new risk - an attacker can create a new thread with the same ID as an existing thin thread. Not sure how useful this attack could be. Protecting against it is handled in https://linear.app/comm/issue/ENG-9468/introduce-additional-validation-of-operations.

https://linear.app/comm/issue/ENG-9823/fix-sending-notifs-about-leaving-a-thick-thread

Depends on D13698

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 31 2024, 7:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 31 2024, 7:59 AM

tomek added a child revision: D13843: [lib] Merge generating notifs data with processing operations.Oct 31 2024, 8:03 AM

Harbormaster completed remote builds in B32476: Diff 45509.Oct 31 2024, 8:17 AM

tomek requested review of this revision.Oct 31 2024, 8:17 AM

This diff introduces a new risk - an attacker can create a new thread with the same ID as an existing thin thread. Not sure how useful this attack could be. Protecting against it is handled in https://linear.app/comm/issue/ENG-9468/introduce-additional-validation-of-operations.

I'm a bit skeptical about introducing this regression. The task you linked is unlikely to be prioritized anytime soon.

In D13842#386643, @ashoat wrote:

This diff introduces a new risk - an attacker can create a new thread with the same ID as an existing thin thread. Not sure how useful this attack could be. Protecting against it is handled in https://linear.app/comm/issue/ENG-9468/introduce-additional-validation-of-operations.

I'm a bit skeptical about introducing this regression. The task you linked is unlikely to be prioritized anytime soon.

Introducing protection against this is a really quick fix (30 min?) to implement, and I think we can create a subtask out of that task and prioritize it.

Makes sense to me!

Created https://linear.app/comm/issue/ENG-9826/validate-the-ids-from-the-dm-operations to track the validation and assigned it to the cycle.

kamil accepted this revision.Nov 5 2024, 1:44 AM

This revision is now accepted and ready to land.Nov 5 2024, 1:44 AM

Closed by commit rCOMM580b6451cbab: [lib] Tighten utils type to contain only thick threads (authored by tomek). · Explain WhyNov 8 2024, 4:29 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM580b6451cbab: [lib] Tighten utils type to contain only thick threads.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

add-members-spec.js

11 lines

add-viewer-to-thread-members-spec.js

7 lines

change-thread-read-status-spec.js

2 lines

change-thread-settings-spec.js

4 lines

change-thread-subscription.js

1 line

create-thread-spec.js

5 lines

4 lines

3 lines

2 lines

11 lines

14 lines

remove-members-spec.js

2 lines

Diff 45709

View Options

lib/shared/dm-ops/add-members-spec.js

Show All 13 Lines	import {
useSearchMessages as useSearchMessagesAction,		useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js';		} from '../actions/message-actions.js';
import {		import {
searchUsers,		searchUsers,
searchUsersActionTypes,		searchUsersActionTypes,
} from '../actions/user-actions.js';		} from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js';		import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js';		import genesis from '../facts/genesis.js';
		import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type {		import type {
ChatMessageInfoItem,		ChatMessageInfoItem,
MessageListData,		MessageListData,
} from '../selectors/chat-selectors.js';		} from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js';		import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';		import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
		import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';		import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';		import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js';		import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';		import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type {		import type {
AccountUserInfo,		AccountUserInfo,
GlobalAccountUserInfo,		GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines	void (async () => {
setUsernameToSearch(lowercaseText);		setUsernameToSearch(lowercaseText);
}		}
})();		})();
}, [ensCache, lowercaseText]);		}, [ensCache, lowercaseText]);

return usernameToSearch;		return usernameToSearch;
}		}

		function useSearchIdentityUsers(
		usernameInputText: string,
		): $ReadOnlyArray<User> {
		const currentUserID = useSelector(
		state => state.currentUserInfo && state.currentUserInfo.id,
		);

		const { sendPrefixQuery } = useIdentitySearch();
		const [searchResults, setSearchResults] = React.useState(
		ashoatUnsubmitted Not Done Inline Actions Same comment here... please move the typehint ashoat: Same comment here... please move the typehint
		ashoatUnsubmitted Not Done Inline Actions Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here. In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid. Okay to skip it this time I guess ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
		willAuthorUnsubmitted Done Inline Actions Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward. will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
		([]: $ReadOnlyArray<User>),
		);

		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

		React.useEffect(() => {
		if (forwardLookupSearchText.length === 0) {
		setSearchResults([]);
		return;
		}

		void (async () => {
		try {
		const result = await sendPrefixQuery(forwardLookupSearchText);
		setSearchResults(
		result.filter(({ userID }) => userID !== currentUserID),
		);
		} catch (err) {
		console.error(err);
		setSearchResults([]);
		}
		})();
		}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);

		return searchResults;
		}

function useSearchUsers(		function useSearchUsers(
usernameInputText: string,		usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> {		): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector(		const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,		state => state.currentUserInfo && state.currentUserInfo.id,
);		);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines	): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems;		return sortedChatMessageInfoItems;
}		}

export {		export {
usePotentialMemberItems,		usePotentialMemberItems,
notFriendNotice,		notFriendNotice,
useSearchMessages,		useSearchMessages,
useSearchUsers,		useSearchUsers,
		useSearchIdentityUsers,
filterChatMessageInfosForSearch,		filterChatMessageInfosForSearch,
useForwardLookupSearchText,		useForwardLookupSearchText,
};		};

View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Show All 13 Lines	import {
useSearchMessages as useSearchMessagesAction,		useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js';		} from '../actions/message-actions.js';
import {		import {
searchUsers,		searchUsers,
searchUsersActionTypes,		searchUsersActionTypes,
} from '../actions/user-actions.js';		} from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js';		import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js';		import genesis from '../facts/genesis.js';
		import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type {		import type {
ChatMessageInfoItem,		ChatMessageInfoItem,
MessageListData,		MessageListData,
} from '../selectors/chat-selectors.js';		} from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js';		import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';		import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
		import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';		import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';		import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js';		import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';		import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type {		import type {
AccountUserInfo,		AccountUserInfo,
GlobalAccountUserInfo,		GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines	void (async () => {
setUsernameToSearch(lowercaseText);		setUsernameToSearch(lowercaseText);
}		}
})();		})();
}, [ensCache, lowercaseText]);		}, [ensCache, lowercaseText]);

return usernameToSearch;		return usernameToSearch;
}		}

		function useSearchIdentityUsers(
		usernameInputText: string,
		): $ReadOnlyArray<User> {
		const currentUserID = useSelector(
		state => state.currentUserInfo && state.currentUserInfo.id,
		);

		const { sendPrefixQuery } = useIdentitySearch();
		const [searchResults, setSearchResults] = React.useState(
		ashoatUnsubmitted Not Done Inline Actions Same comment here... please move the typehint ashoat: Same comment here... please move the typehint
		ashoatUnsubmitted Not Done Inline Actions Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here. In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid. Okay to skip it this time I guess ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
		willAuthorUnsubmitted Done Inline Actions Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward. will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
		([]: $ReadOnlyArray<User>),
		);

		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

		React.useEffect(() => {
		if (forwardLookupSearchText.length === 0) {
		setSearchResults([]);
		return;
		}

		void (async () => {
		try {
		const result = await sendPrefixQuery(forwardLookupSearchText);
		setSearchResults(
		result.filter(({ userID }) => userID !== currentUserID),
		);
		} catch (err) {
		console.error(err);
		setSearchResults([]);
		}
		})();
		}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);

		return searchResults;
		}

function useSearchUsers(		function useSearchUsers(
usernameInputText: string,		usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> {		): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector(		const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,		state => state.currentUserInfo && state.currentUserInfo.id,
);		);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines	): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems;		return sortedChatMessageInfoItems;
}		}

export {		export {
usePotentialMemberItems,		usePotentialMemberItems,
notFriendNotice,		notFriendNotice,
useSearchMessages,		useSearchMessages,
useSearchUsers,		useSearchUsers,
		useSearchIdentityUsers,
filterChatMessageInfosForSearch,		filterChatMessageInfosForSearch,
useForwardLookupSearchText,		useForwardLookupSearchText,
};		};

View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

Show All 13 Lines	import {
useSearchMessages as useSearchMessagesAction,		useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js';		} from '../actions/message-actions.js';
import {		import {
searchUsers,		searchUsers,
searchUsersActionTypes,		searchUsersActionTypes,
} from '../actions/user-actions.js';		} from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js';		import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js';		import genesis from '../facts/genesis.js';
		import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type {		import type {
ChatMessageInfoItem,		ChatMessageInfoItem,
MessageListData,		MessageListData,
} from '../selectors/chat-selectors.js';		} from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js';		import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';		import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
		import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';		import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';		import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js';		import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';		import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type {		import type {
AccountUserInfo,		AccountUserInfo,
GlobalAccountUserInfo,		GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines	void (async () => {
setUsernameToSearch(lowercaseText);		setUsernameToSearch(lowercaseText);
}		}
})();		})();
}, [ensCache, lowercaseText]);		}, [ensCache, lowercaseText]);

return usernameToSearch;		return usernameToSearch;
}		}

		function useSearchIdentityUsers(
		usernameInputText: string,
		): $ReadOnlyArray<User> {
		const currentUserID = useSelector(
		state => state.currentUserInfo && state.currentUserInfo.id,
		);

		const { sendPrefixQuery } = useIdentitySearch();
		const [searchResults, setSearchResults] = React.useState(
		ashoatUnsubmitted Not Done Inline Actions Same comment here... please move the typehint ashoat: Same comment here... please move the typehint
		ashoatUnsubmitted Not Done Inline Actions Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here. In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid. Okay to skip it this time I guess ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
		willAuthorUnsubmitted Done Inline Actions Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward. will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
		([]: $ReadOnlyArray<User>),
		);

		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

		React.useEffect(() => {
		if (forwardLookupSearchText.length === 0) {
		setSearchResults([]);
		return;
		}

		void (async () => {
		try {
		const result = await sendPrefixQuery(forwardLookupSearchText);
		setSearchResults(
		result.filter(({ userID }) => userID !== currentUserID),
		);
		} catch (err) {
		console.error(err);
		setSearchResults([]);
		}
		})();
		}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);

		return searchResults;
		}

function useSearchUsers(		function useSearchUsers(
usernameInputText: string,		usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> {		): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector(		const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,		state => state.currentUserInfo && state.currentUserInfo.id,
);		);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines	): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems;		return sortedChatMessageInfoItems;
}		}

export {		export {
usePotentialMemberItems,		usePotentialMemberItems,
notFriendNotice,		notFriendNotice,
useSearchMessages,		useSearchMessages,
useSearchUsers,		useSearchUsers,
		useSearchIdentityUsers,
filterChatMessageInfosForSearch,		filterChatMessageInfosForSearch,
useForwardLookupSearchText,		useForwardLookupSearchText,
};		};

View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show All 13 Lines	import {
useSearchMessages as useSearchMessagesAction,		useSearchMessages as useSearchMessagesAction,
} from '../actions/message-actions.js';		} from '../actions/message-actions.js';
import {		import {
searchUsers,		searchUsers,
searchUsersActionTypes,		searchUsersActionTypes,
} from '../actions/user-actions.js';		} from '../actions/user-actions.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js';		import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import genesis from '../facts/genesis.js';		import genesis from '../facts/genesis.js';
		import { useIdentitySearch } from '../identity-search/identity-search-context.js';
import type {		import type {
ChatMessageInfoItem,		ChatMessageInfoItem,
MessageListData,		MessageListData,
} from '../selectors/chat-selectors.js';		} from '../selectors/chat-selectors.js';
import { useUserSearchIndex } from '../selectors/nav-selectors.js';		import { useUserSearchIndex } from '../selectors/nav-selectors.js';
import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';		import { relationshipBlockedInEitherDirection } from '../shared/relationship-utils.js';
		import type { User } from '../types/identity-search/search-response-types.js';
import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';		import type { MessageInfo, RawMessageInfo } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';		import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadPermissions } from '../types/thread-permission-types.js';		import { threadPermissions } from '../types/thread-permission-types.js';
import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';		import { type ThreadType, threadTypes } from '../types/thread-types-enum.js';
import type {		import type {
AccountUserInfo,		AccountUserInfo,
GlobalAccountUserInfo,		GlobalAccountUserInfo,
▲ Show 20 Lines • Show All 328 Lines • ▼ Show 20 Lines	void (async () => {
setUsernameToSearch(lowercaseText);		setUsernameToSearch(lowercaseText);
}		}
})();		})();
}, [ensCache, lowercaseText]);		}, [ensCache, lowercaseText]);

return usernameToSearch;		return usernameToSearch;
}		}

		function useSearchIdentityUsers(
		usernameInputText: string,
		): $ReadOnlyArray<User> {
		const currentUserID = useSelector(
		state => state.currentUserInfo && state.currentUserInfo.id,
		);

		const { sendPrefixQuery } = useIdentitySearch();
		const [searchResults, setSearchResults] = React.useState(
		ashoatUnsubmitted Not Done Inline Actions Same comment here... please move the typehint ashoat: Same comment here... please move the typehint
		ashoatUnsubmitted Not Done Inline Actions Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here. In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid. Okay to skip it this time I guess ashoat: Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping…
		willAuthorUnsubmitted Done Inline Actions Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward. will: Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback…
		([]: $ReadOnlyArray<User>),
		);

		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

		React.useEffect(() => {
		if (forwardLookupSearchText.length === 0) {
		setSearchResults([]);
		return;
		}

		void (async () => {
		try {
		const result = await sendPrefixQuery(forwardLookupSearchText);
		setSearchResults(
		result.filter(({ userID }) => userID !== currentUserID),
		);
		} catch (err) {
		console.error(err);
		setSearchResults([]);
		}
		})();
		}, [currentUserID, forwardLookupSearchText, sendPrefixQuery]);

		return searchResults;
		}

function useSearchUsers(		function useSearchUsers(
usernameInputText: string,		usernameInputText: string,
): $ReadOnlyArray<GlobalAccountUserInfo> {		): $ReadOnlyArray<GlobalAccountUserInfo> {
const currentUserID = useSelector(		const currentUserID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id,		state => state.currentUserInfo && state.currentUserInfo.id,
);		);
const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);		const forwardLookupSearchText = useForwardLookupSearchText(usernameInputText);

▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines	): ?(ChatMessageInfoItem[]) {
return sortedChatMessageInfoItems;		return sortedChatMessageInfoItems;
}		}

export {		export {
usePotentialMemberItems,		usePotentialMemberItems,
notFriendNotice,		notFriendNotice,
useSearchMessages,		useSearchMessages,
useSearchUsers,		useSearchUsers,
		useSearchIdentityUsers,
filterChatMessageInfosForSearch,		filterChatMessageInfosForSearch,
useForwardLookupSearchText,		useForwardLookupSearchText,
};		};