[lib] Delete remove members spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2024, 3:06 PM.

Details

Reviewers

kamil
angelika

Commits

rCOMM58824ef48b2e: [lib] Delete remove members spec

Summary

We don't support removing members and maintaining this code doesn't make sense.

https://linear.app/comm/issue/ENG-9823/fix-sending-notifs-about-leaving-a-thick-thread

Depends on D13843

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 31 2024, 3:06 PM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 31 2024, 3:06 PM

tomek added a child revision: D13848: [lib] Propagate thread infos to the notifs generating code.Oct 31 2024, 3:20 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 31 2024, 3:20 PM

Harbormaster failed remote builds in B32479: Diff 45512!

Rebase

Harbormaster completed remote builds in B32488: Diff 45521.Oct 31 2024, 4:56 PM

tomek requested review of this revision.Oct 31 2024, 4:56 PM

kamil accepted this revision.Oct 31 2024, 6:03 PM

This revision is now accepted and ready to land.Oct 31 2024, 6:03 PM

Closed by commit rCOMM58824ef48b2e: [lib] Delete remove members spec. · Explain WhyNov 8 2024, 12:29 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM58824ef48b2e: [lib] Delete remove members spec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-op-specs.js

2 lines

remove-members-spec.js

types/

dm-ops.js

21 lines

Diff 45710

View Options

lib/shared/dm-ops/dm-op-specs.js

View Options

lib/shared/dm-ops/remove-members-spec.js

View Options

[lib] Delete remove members specClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45710

lib/shared/dm-ops/dm-op-specs.js

lib/shared/dm-ops/remove-members-spec.js

lib/types/dm-ops.js

[lib] Delete remove members spec
ClosedPublic
Actions

Revision Contents
Changeset List