Page MenuHomePhabricator
Differential D13845

[lib] Delete remove members spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2024, 8:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 10:57 AM
Unknown Object (File)
Fri, Mar 28, 6:55 AM
Unknown Object (File)
Fri, Mar 28, 12:30 AM
Unknown Object (File)
Thu, Mar 27, 11:06 PM
Unknown Object (File)
Thu, Mar 27, 6:36 AM
Unknown Object (File)
Feb 18 2025, 2:37 PM
Unknown Object (File)
Feb 18 2025, 2:37 PM
Unknown Object (File)
Feb 18 2025, 2:37 PM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
kamil
angelika
Commits
rCOMM58824ef48b2e: [lib] Delete remove members spec
Summary

We don't support removing members and maintaining this code doesn't make sense.

https://linear.app/comm/issue/ENG-9823/fix-sending-notifs-about-leaving-a-thick-thread

Depends on D13843

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
types/
21 lines

Diff 45710

View Options

lib/shared/dm-ops/dm-op-specs.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/remove-members-spec.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines