Page MenuHomePhabricator

[services] Allow browsers to access prod identity from comm.software
ClosedPublic

Authored by ashoat on Tue, Nov 5, 9:56 AM.
Tags
None
Referenced Files
F3167016: D13881.diff
Thu, Nov 7, 3:20 AM
F3166159: D13881.diff
Thu, Nov 7, 12:38 AM
F3166016: D13881.diff
Wed, Nov 6, 11:49 PM
F3165676: D13881.id45623.diff
Wed, Nov 6, 10:34 PM
F3165675: D13881.id45622.diff
Wed, Nov 6, 10:34 PM
F3165674: D13881.id45621.diff
Wed, Nov 6, 10:34 PM
F3165657: D13881.diff
Wed, Nov 6, 10:34 PM
F3165533: D13881.id.diff
Wed, Nov 6, 10:04 PM
Subscribers

Details

Summary

This diff updates the CORS config for the identity service in production to allow incoming connections from browsers rendering comm.software and www.comm.software.

Context for why we need this is in ENG-9862.

Test Plan

Terraform precommit hooks passed. Beyond that, not sure how to test this besides deploying to prod...

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/identity
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Don't include port in web.comm.app

ashoat published this revision for review.Tue, Nov 5, 9:57 AM
ashoat edited the test plan for this revision. (Show Details)
varun accepted this revision.EditedTue, Nov 5, 9:59 AM

do you need the www origin?

This revision is now accepted and ready to land.Tue, Nov 5, 9:59 AM

For SLDs I've always included www.. Probably not as relevant anymore, but in the past it was something that some computers and some people would include when navigating to an SLD

This revision was landed with ongoing or failed builds.Tue, Nov 5, 10:02 AM
This revision was automatically updated to reflect the committed changes.

This was an unsafe change and is causing deployment failures in production. I think @varun was wrong in his assessment that the port could be skipped for web.comm.app.