[services] Bump production identity to 0.45
ClosedPublic
Actions

Authored by ashoat on Tue, Nov 5, 12:25 PM.

Details

Reviewers

varun
will
bartek

Commits

rCOMMcde77ed6d5fc: [services] Bump production identity to 0.45

Summary

This includes D13883.

Test Plan

I'll confirm that staging successfully deploys without issue
Once staging is deployed, I'll confirm that I'm still able to log in to staging identity

I won't land this until both are confirmed.

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/tf

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Tue, Nov 5, 12:25 PM

Herald added a subscriber: tomek. · View Herald TranscriptTue, Nov 5, 12:25 PM

ashoat published this revision for review.Tue, Nov 5, 12:25 PM

I'll confirm that staging successfully deploys without issue

Once staging is deployed, I'll confirm that I'm still able to log in to staging identity

I won't land this until both are confirmed.

Test plan is concluded

We normally wait a day before promoting a version from staging to prod

I don't love that we're breaking precedent here, but since we are, I compared 0.44 and 0.45 on GitHub to make sure we're not accidentally including any other changes. I don't see any changes to shared/ or services/identity besides the ones in D13883, so this appears safe

This revision is now accepted and ready to land.Tue, Nov 5, 12:40 PM

Harbormaster completed remote builds in B32555: Diff 45631.Tue, Nov 5, 12:43 PM

In D13885#387606, @varun wrote:

We normally wait a day before promoting a version from staging to prod

I don't love that we're breaking precedent here, but since we are, I compared 0.44 and 0.45 on GitHub to make sure we're not accidentally including any other changes. I don't see any changes to shared/ or services/identity besides the ones in D13883, so this appears safe

That's fair – I probably should've preempted this concern and explained my reasoning.

My perspective is basically what you've described... the only change here is D13883, and it simply removes a check that can cause a fatal. In contrast with D13881 which triggered my "spidey senses" a bit, this change feels almost certainly safe to me.