Page MenuHomePhabricator
Differential D13894

[CommCoreModule] make sure `backupID` is URL-safe string
ClosedPublic
Actions

Authored by kamil on Nov 7 2024, 7:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 1:26 PM
Unknown Object (File)
Wed, Mar 12, 1:26 PM
Unknown Object (File)
Wed, Mar 12, 1:25 PM
Unknown Object (File)
Wed, Mar 12, 1:25 PM
Unknown Object (File)
Feb 19 2025, 10:02 PM
Unknown Object (File)
Jan 13 2025, 2:00 AM
Unknown Object (File)
Jan 13 2025, 2:00 AM
Unknown Object (File)
Jan 13 2025, 1:59 AM
View All 43 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMa2b0d2a52444: [CommCoreModule] make sure `backupID` is URL-safe string
Summary

ENG-9728.

Not sure if we need any additional conversion, this should be enough.

Test Plan

Test uploading backup

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
1 line
6 lines
NativeModules/
2 lines

Diff 45734

View Options

native/cpp/CommonCpp/CryptoTools/Tools.h

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/CryptoTools/Tools.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Linesimport type {
MessageStorePrunePayload, MessageStorePrunePayload,
LocallyComposedMessageInfo, LocallyComposedMessageInfo,
SimpleMessagesPayload, SimpleMessagesPayload,
FetchPinnedMessagesResult, FetchPinnedMessagesResult,
SearchMessagesResponse, SearchMessagesResponse,
} from './message-types.js'; } from './message-types.js';
import type { RawReactionMessageInfo } from './messages/reaction.js'; import type { RawReactionMessageInfo } from './messages/reaction.js';
import type { RawTextMessageInfo } from './messages/text.js'; import type { RawTextMessageInfo } from './messages/text.js';
import type { BaseNavInfo } from './nav-types.js'; import type { BaseNavInfo, WebNavInfo } from './nav-types.js';
import { import {
type ForcePolicyAcknowledgmentPayload, type ForcePolicyAcknowledgmentPayload,
type PolicyAcknowledgmentPayload, type PolicyAcknowledgmentPayload,
type UserPolicies, type UserPolicies,
} from './policy-types.js'; } from './policy-types.js';
import type { RelationshipErrors } from './relationship-types.js'; import type { RelationshipErrors } from './relationship-types.js';
import type { import type {
EnabledReports, EnabledReports,
Show All 24 Lines
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
ToggleMessagePinResult, ToggleMessagePinResult,
LegacyThreadStore,
RoleModificationPayload, RoleModificationPayload,
RoleDeletionPayload, RoleDeletionPayload,
} from './thread-types.js'; } from './thread-types.js';
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
Show All 24 Lines
export type NativeAppState = BaseAppState<>; export type NativeAppState = BaseAppState<>;
export type WebAppState = BaseAppState<> & { export type WebAppState = BaseAppState<> & {
+cryptoStore: ?CryptoStore, +cryptoStore: ?CryptoStore,
+pushApiPublicKey: ?string, +pushApiPublicKey: ?string,
... ...
}; };
export type AppState = NativeAppState | WebAppState; export type AppState = NativeAppState | WebAppState;
export type WebInitialReduxStateResponse = {
+navInfo: WebNavInfo,
+currentUserInfo: CurrentUserInfo,
+entryStore: EntryStore,
+threadStore: LegacyThreadStore,
+userInfos: UserInfos,
+messageStore: MessageStore,
+pushApiPublicKey: ?string,
+commServicesAccessToken: null,
+inviteLinksStore: InviteLinksStore,
+keyserverInfo: WebInitialKeyserverInfo,
};
export type WebInitialKeyserverInfo = {
+sessionID: ?string,
+updatesCurrentAsOf: number,
};
export type BaseAction = export type BaseAction =
| { | {
+type: '@@redux/INIT', +type: '@@redux/INIT',
+payload?: void, +payload?: void,
} }
| { | {
+type: 'FETCH_ENTRIES_STARTED', +type: 'FETCH_ENTRIES_STARTED',
+payload?: void, +payload?: void,
▲ Show 20 Lines • Show All 1,154 Lines • Show Last 20 Lines