[CommCoreModule] make sure `backupID` is URL-safe string
AcceptedPublic
Actions

Authored by kamil on Thu, Nov 7, 7:17 AM.

Details

Reviewers

varun
bartek

Summary

ENG-9728.

Not sure if we need any additional conversion, this should be enough.

Test Plan

Test uploading backup

Diff Detail

Repository

rCOMM Comm

Branch

backup-id-gen

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Nov 7, 7:17 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Nov 7, 7:17 AM

Harbormaster completed remote builds in B32577: Diff 45692.Thu, Nov 7, 7:37 AM

kamil published this revision for review.Thu, Nov 7, 8:13 AM

varun accepted this revision.Thu, Nov 7, 11:38 AM

This revision is now accepted and ready to land.Thu, Nov 7, 11:38 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

Tools.h

1 line

Tools.cpp

6 lines

NativeModules/

CommCoreModule.cpp

2 lines

Diff 45692

View Options

native/cpp/CommonCpp/CryptoTools/Tools.h

View Options

native/cpp/CommonCpp/CryptoTools/Tools.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[CommCoreModule] make sure `backupID` is URL-safe stringAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45692

native/cpp/CommonCpp/CryptoTools/Tools.h

native/cpp/CommonCpp/CryptoTools/Tools.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[CommCoreModule] make sure `backupID` is URL-safe string
AcceptedPublic
Actions

Revision Contents
Changeset List