Page MenuHomePhabricator
Differential D13938

[lib] Use useUsersSupportThickThreads() (with auxUserInfos) in useUpdateRelationships()
ClosedPublic
Actions

Authored by angelika on Nov 14 2024, 12:49 PM.
Tags
None
Referenced Files
F3516523: D13938.diff
Sun, Dec 22, 2:48 PM
F3513302: D13938.id46376.diff
Sat, Dec 21, 11:34 PM
F3511772: D13938.id46373.diff
Sat, Dec 21, 4:01 PM
Unknown Object (File)
Sat, Dec 21, 10:25 AM
Unknown Object (File)
Fri, Dec 20, 10:32 PM
Unknown Object (File)
Mon, Dec 16, 4:05 PM
Unknown Object (File)
Sun, Dec 15, 7:10 AM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
View All 31 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMMfa259c0d3023: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in…
Summary

https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Test Plan
  1. Mobile user makes a new thick thread with web user (with new message button)
  2. Mobile user sends friend request
  3. Throw some error in fetchUserIdentitiesPromise() so that finding user indentity always fails
  4. Web user accepts the request
  5. Before a new thin thread was created. Now no new threads are created, users are friends, because user identity is found in auxUserInfo.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Nov 14 2024, 12:49 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 14 2024, 12:49 PM
angelika added a child revision: D13939: [lib] Consider thread infos in useUsersSupportThickThreads().Nov 14 2024, 12:50 PM
ashoat mentioned this in D13940: [lib] Don't swallow errors in getUserIdentities() call.Nov 14 2024, 1:10 PM
ashoat mentioned this in D13939: [lib] Consider thread infos in useUsersSupportThickThreads().Nov 14 2024, 1:33 PM
Harbormaster completed remote builds in B32670: Diff 45829.Nov 14 2024, 2:06 PM
angelika requested review of this revision.Nov 14 2024, 2:06 PM
kamil accepted this revision.Nov 18 2024, 1:57 AM
This revision is now accepted and ready to land.Nov 18 2024, 1:57 AM
angelika updated this revision to Diff 45973.Nov 22 2024, 1:12 PM

Rebase

angelika added a child revision: D14022: [lib] Check if device list exists instead of using userHasDeviceList() in useUsersSupportThickThreads().Nov 22 2024, 1:17 PM
Harbormaster completed remote builds in B32786: Diff 45973.Nov 22 2024, 1:29 PM
angelika updated this revision to Diff 46373.Thu, Dec 12, 4:42 AM

Rebase

Harbormaster completed remote builds in B33055: Diff 46373.Thu, Dec 12, 4:59 AM
Closed by commit rCOMMfa259c0d3023: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in… (authored by angelika). · Explain WhyThu, Dec 12, 5:23 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMfa259c0d3023: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in….

Revision Contents
Changeset List

PathSize
lib/
hooks/
11 lines

Diff 46373

View Options

lib/hooks/relationship-hooks.js

Loading...