Page MenuHomePhabricator
Differential D13950

[native] Make sure all virtual classes in C++ code base have virtual destructor
ClosedPublic
Actions

Authored by angelika on Fri, Nov 15, 1:26 PM.
Tags
None
Referenced Files
F3363708: D13950.id.diff
Mon, Nov 25, 3:08 AM
F3363062: D13950.id45880.diff
Sun, Nov 24, 11:53 PM
F3362067: D13950.id45857.diff
Sun, Nov 24, 9:13 PM
F3361907: D13950.id45881.diff
Sun, Nov 24, 8:17 PM
Unknown Object (File)
Sun, Nov 24, 2:04 AM
Unknown Object (File)
Sat, Nov 23, 5:58 PM
Unknown Object (File)
Fri, Nov 22, 6:05 PM
Unknown Object (File)
Thu, Nov 21, 1:40 PM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM7a608523bf85: [native] Make sure all virtual classes in C++ code base have virtual destructor
Summary

https://linear.app/comm/issue/ENG-2329/make-sure-all-virtual-classes-in-c-code-base-have-virtual-destructor

Test Plan

Compile the app and make sure there are no more warnings related to missing virtual destructors

Diff Detail

Repository
rCOMM Comm
Branch
graszka22/ENG-2329
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Fri, Nov 15, 1:26 PM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Nov 15, 1:26 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Nov 15, 1:34 PM
Harbormaster failed remote builds in B32690: Diff 45853!
Harbormaster completed remote builds in B32690: Diff 45853.Fri, Nov 15, 1:52 PM
angelika requested review of this revision.Fri, Nov 15, 1:52 PM
kamil accepted this revision.Mon, Nov 18, 1:19 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
213 ↗(On Diff #45853)

I would put this in line 193, where we have "shared" methods defined before methods defined via directives

This revision is now accepted and ready to land.Mon, Nov 18, 1:19 AM
angelika updated this revision to Diff 45855.Mon, Nov 18, 4:29 AM

Review comments

Harbormaster completed remote builds in B32691: Diff 45855.Mon, Nov 18, 8:10 AM
Closed by commit rCOMM7a608523bf85: [native] Make sure all virtual classes in C++ code base have virtual destructor (authored by angelika). · Explain WhyTue, Nov 19, 3:30 AM
This revision was automatically updated to reflect the committed changes.
angelika marked an inline comment as done.
angelika added a commit: rCOMM7a608523bf85: [native] Make sure all virtual classes in C++ code base have virtual destructor.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
1 line
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
MessageSpecs/
2 lines
web/
shared-worker/
_generated/

Diff 45855

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MessageSpec.h

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...