Paths

Table of Contentst

[lib] refactor `useClientBackup` to not use user identifier from the store
ClosedPublic
Actions

Authored by kamil on Dec 5 2024, 12:24 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMMde39757b9ad9: [lib] refactor `useClientBackup` to not use user identifier from the store

Summary

ENG-8195.

Previous API was wrong, we don't have username in the store when performing restore

Depends on D14079

Test Plan

Play with backup menu and see if this still works

Diff Detail

Repository

rCOMM Comm

Branch

restore

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 5 2024, 12:24 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 5 2024, 12:24 PM

kamil added a child revision: D14081: [lib] add Identity Restore action type.Dec 5 2024, 12:32 PM

Harbormaster completed remote builds in B32932: Diff 46216.Dec 5 2024, 12:41 PM

kamil published this revision for review.Dec 6 2024, 9:41 AM

bartek accepted this revision.Dec 6 2024, 10:26 AM

This revision is now accepted and ready to land.Dec 6 2024, 10:26 AM

Closed by commit rCOMMde39757b9ad9: [lib] refactor `useClientBackup` to not use user identifier from the store. · Explain WhyDec 11 2024, 1:39 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMde39757b9ad9: [lib] refactor `useClientBackup` to not use user identifier from the store.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

10 lines

use-client-backup.js

38 lines

profile/

backup-menu.react.js

44 lines

Diff 46216

View Options

native/backup/backup-handler.js

View Options

native/backup/use-client-backup.js

View Options

native/profile/backup-menu.react.js

[lib] refactor `useClientBackup` to not use user identifier from the storeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46216

native/backup/backup-handler.js

native/backup/use-client-backup.js

native/profile/backup-menu.react.js

[lib] refactor `useClientBackup` to not use user identifier from the store
ClosedPublic
Actions

Revision Contents
Changeset List