[native] make sure `start_backup_handler` is called only once in `BackupHandler`
ClosedPublic
Actions

Authored by kamil on Dec 11 2024, 12:34 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM8a23992d6ba2: [native] make sure `start_backup_handler` is called only once in `BackupHandler`

Summary

ENG-10001.

The asynchronous nature of this effect caused this promise to be spawned a couple of times, resulting in the starting handler multiple times.

Depends on D14095

Test Plan

Added some logs to make sure there is only one call to startBackupHandler

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 11 2024, 12:34 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 11 2024, 12:34 PM

kamil edited the summary of this revision. (Show Details)Dec 11 2024, 12:35 PM

kamil added a child revision: D14097: [CommCoreModule] avoid triggering backup upload on SQLite changes.Dec 11 2024, 12:36 PM

Harbormaster completed remote builds in B32993: Diff 46307.Dec 11 2024, 12:56 PM

kamil published this revision for review.Dec 11 2024, 1:05 PM

bartek accepted this revision.Dec 12 2024, 6:43 AM

This revision is now accepted and ready to land.Dec 12 2024, 6:43 AM

Closed by commit rCOMM8a23992d6ba2: [native] make sure `start_backup_handler` is called only once in `BackupHandler`. · Explain WhyDec 17 2024, 12:27 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM8a23992d6ba2: [native] make sure `start_backup_handler` is called only once in `BackupHandler`.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

6 lines

Diff 46535

View Options

native/backup/backup-handler.js

[native] make sure `start_backup_handler` is called only once in `BackupHandler`ClosedPublicActions