[CommCoreModule] avoid triggering backup upload on SQLite changes
ClosedPublic
Actions

Authored by kamil on Dec 11 2024, 12:36 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM271fb24f3a47: [CommCoreModule] avoid triggering backup upload on SQLite changes

Summary

ENG-10001.

This is triggered on any DB write operation, we can avoid it and bring it back when having User Data.

Adding this to ENG-9921

Depends on D14096

Test Plan

Made some changes in the app - the backup handler is not triggered.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 11 2024, 12:36 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 11 2024, 12:36 PM

kamil edited the test plan for this revision. (Show Details)Dec 11 2024, 12:36 PM

Harbormaster completed remote builds in B32994: Diff 46308.Dec 11 2024, 1:04 PM

kamil published this revision for review.Dec 11 2024, 1:05 PM

bartek accepted this revision.Dec 12 2024, 8:34 AM

This revision is now accepted and ready to land.Dec 12 2024, 8:34 AM

Closed by commit rCOMM271fb24f3a47: [CommCoreModule] avoid triggering backup upload on SQLite changes. · Explain WhyDec 17 2024, 12:27 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM271fb24f3a47: [CommCoreModule] avoid triggering backup upload on SQLite changes.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

4 lines

PersistentStorageUtilities/

DataStores/

BaseDataStore.h

2 lines

Diff 46536

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp