Paths

Table of Contentst

[native][web] Merge logout buttons for old and new flows
ClosedPublic
Actions

Authored by bartek on Dec 12 2024, 3:22 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows

Summary

Address ENG-9688.

Removed the experimental buttons for new logout flows
Main logout button behavior depends on usingRestoreFlow:
- legacy logout (current behavior) if false
- Primary/secondary logout if true

Depends on D14146

Test Plan

Changed the flag true/false and pressed logout button. Made sure correct procedure is executed

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 12 2024, 3:22 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 12 2024, 3:22 PM

Harbormaster failed remote builds in B33059: Diff 46380!Dec 12 2024, 3:48 PM

Rebase

Harbormaster completed remote builds in B33062: Diff 46383.Dec 12 2024, 4:12 PM

bartek published this revision for review.Dec 13 2024, 7:28 AM

kamil accepted this revision.Dec 16 2024, 2:02 PM

kamil added inline comments.

native/profile/profile-screen.react.js
361–364 ↗	(On Diff #46383)	are you sure we don't want to show Alerts that are implemented below and early return?

This revision is now accepted and ready to land.Dec 16 2024, 2:02 PM

bartek added inline comments.Dec 16 2024, 2:45 PM

native/profile/profile-screen.react.js
361–364 ↗	(On Diff #46383)	Yes. `onPressNewLogout()` has its own alerts

Closed by commit rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows. · Explain WhyDec 16 2024, 2:48 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows.

Revision Contents
Changeset List

Path

Size

native/

profile/

profile-screen.react.js

19 lines

web/

settings/

account-settings.react.js

37 lines

Diff 46380

View Options

native/profile/profile-screen.react.js