Page MenuHomePhabricator

[identity] Force v1 primary logout for authoritative keyserver owner
ClosedPublic

Authored by bartek on Dec 19 2024, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 6:33 PM
Unknown Object (File)
Wed, Mar 26, 9:43 AM
Unknown Object (File)
Wed, Mar 26, 6:01 AM
Unknown Object (File)
Tue, Mar 25, 10:44 AM
Unknown Object (File)
Sat, Mar 15, 4:25 PM
Unknown Object (File)
Sat, Mar 15, 4:25 PM
Unknown Object (File)
Sat, Mar 15, 4:25 PM
Unknown Object (File)
Sat, Mar 15, 4:25 PM
Subscribers

Details

Summary

Address ENG-10013.

Depends on D14172

Test Plan
  • Mocked AUTHORITATIVE_KEYSERVER_OWNER_USER_ID to be my user ID.
  • Logged in a keyserver
  • On a mobile device, performed primary device logout.
  • Verified that keyserver wasn't logged out, DDB contains unsigned device list, and backup was removed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Dec 19 2024, 5:18 AM
kamil added inline comments.
services/identity/src/grpc_services/authenticated.rs
482–485 ↗(On Diff #46571)

probably doesn't matter in our use case but I would call this if this is AUTHORITATIVE_KEYSERVER_OWNER_USER_ID and has a keyserver on the device list

This revision is now accepted and ready to land.Dec 19 2024, 7:39 AM
services/identity/src/grpc_services/authenticated.rs
482–485 ↗(On Diff #46571)

I tried to ensure one logout method runs consistently for the same user. If the user is an authoritative keyserver owner, v1 logout should always be expected.