Paths

Table of Contentst

Differential D14173

[identity] Force v1 primary logout for authoritative keyserver owner
AcceptedPublic
Actions

Authored by bartek on Thu, Dec 19, 1:51 AM.

Tags

None

Referenced Files

	F3495437: D14173.diff
	Thu, Dec 19, 8:43 AM

	F3494230: D14173.id46571.diff
	Thu, Dec 19, 4:45 AM

	F3494194: D14173.id.diff
	Thu, Dec 19, 4:44 AM

	F3494177: D14173.diff
	Thu, Dec 19, 4:43 AM

Subscribers

Details

Reviewers

Summary

Address ENG-10013.

Depends on D14172

Test Plan

Mocked AUTHORITATIVE_KEYSERVER_OWNER_USER_ID to be my user ID.
Logged in a keyserver
On a mobile device, performed primary device logout.
Verified that keyserver wasn't logged out, DDB contains unsigned device list, and backup was removed

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Thu, Dec 19, 1:51 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Dec 19, 1:51 AM

bartek added a child revision: D14174: [identity] Optimize Tunnelbroker device data removal.Thu, Dec 19, 1:53 AM

Harbormaster completed remote builds in B33177: Diff 46571.Thu, Dec 19, 2:08 AM

bartek published this revision for review.Thu, Dec 19, 5:18 AM

kamil accepted this revision.Thu, Dec 19, 7:39 AM

kamil added inline comments.

services/identity/src/grpc_services/authenticated.rs
482–485	probably doesn't matter in our use case but I would call this if this is `AUTHORITATIVE_KEYSERVER_OWNER_USER_ID` and has a keyserver on the device list

This revision is now accepted and ready to land.Thu, Dec 19, 7:39 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

20 lines

6 lines

grpc_services/

authenticated.rs

40 lines

Diff 46571

services/identity/src/database/device_list.rs

Loading...

services/identity/src/device_list.rs

Loading...

services/identity/src/grpc_services/authenticated.rs

Loading...