Page MenuHomePhabricator
Differential D14297

[native] Replace some alerts with logs
ClosedPublic
Actions

Authored by tomek on Feb 5 2025, 10:46 AM.
Tags
None
Referenced Files
F4910612: D14297.diff
Fri, Mar 14, 6:22 PM
F4909731: D14297.id46935.diff
Fri, Mar 14, 7:59 AM
F4909730: D14297.id46941.diff
Fri, Mar 14, 7:59 AM
F4909729: D14297.id46925.diff
Fri, Mar 14, 7:59 AM
F4909611: D14297.id.diff
Fri, Mar 14, 7:34 AM
F4909579: D14297.diff
Fri, Mar 14, 7:30 AM
F4908295: D14297.id46935.diff
Fri, Mar 14, 4:44 AM
F4908117: D14297.id46925.diff
Fri, Mar 14, 4:34 AM
View All 59 Files
Subscribers
ashoat

Details

Reviewers
kamil
angelika
Commits
rCOMMac174fe9c31c: [native] Replace some alerts with logs
Summary

It is important that we don't replace alerts that are critical. Also, on the web we aren't handling the logs yet, so we should use the old mechanism.

https://linear.app/comm/issue/ENG-10140/replace-staff-alerts-with-a-log

Depends on D14296

Test Plan

Called addLog on the web and mobile and checked if the behavior is correct.

Diff Detail

Repository
rCOMM Comm
Branch
logs
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Feb 5 2025, 10:46 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 5 2025, 10:46 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 5 2025, 11:07 AM
Harbormaster failed remote builds in B33398: Diff 46925!
tomek updated this revision to Diff 46935.Feb 6 2025, 1:54 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 6 2025, 2:08 AM
Harbormaster failed remote builds in B33408: Diff 46935!
tomek updated this revision to Diff 46941.Feb 6 2025, 4:30 AM

Rebase

Harbormaster completed remote builds in B33412: Diff 46941.Feb 6 2025, 4:56 AM
tomek requested review of this revision.Feb 6 2025, 4:56 AM
kamil accepted this revision.Feb 10 2025, 3:24 AM
This revision is now accepted and ready to land.Feb 10 2025, 3:24 AM
tomek updated this revision to Diff 47008.Feb 11 2025, 8:29 AM

Rebase

Harbormaster completed remote builds in B33475: Diff 47008.Feb 11 2025, 8:47 AM
Closed by commit rCOMMac174fe9c31c: [native] Replace some alerts with logs (authored by tomek). · Explain WhyFeb 12 2025, 3:18 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMac174fe9c31c: [native] Replace some alerts with logs.

Revision Contents
Changeset List

PathSize
lib/
components/
20 lines
shared/
dm-ops/
16 lines
tunnelbroker/
16 lines
web/
79 lines

Diff 46925

View Options

lib/components/debug-logs-context-provider.react.js

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines
function getRolePermissionBlobsForCommunity( function getRolePermissionBlobsForCommunity(
threadType: ThreadType, threadType: ThreadType,
): RolePermissionBlobs { ): RolePermissionBlobs {
const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF; const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF;
const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE; const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE;
const openTopLevelDescendantJoinThread = const openTopLevelDescendantJoinThread =
OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD; OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD;
const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD; const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD;
const openChildAddMembers = OPEN_CHILD + threadPermissions.ADD_MEMBERS;
const genesisMemberPermissions = { const genesisMemberPermissions = {
[threadPermissions.KNOW_OF]: true, [threadPermissions.KNOW_OF]: true,
[threadPermissions.VISIBLE]: true, [threadPermissions.VISIBLE]: true,
[openDescendantKnowOf]: true, [openDescendantKnowOf]: true,
[openDescendantVisible]: true, [openDescendantVisible]: true,
[openTopLevelDescendantJoinThread]: true, [openTopLevelDescendantJoinThread]: true,
}; };
const baseMemberPermissions = { const baseMemberPermissions = {
...genesisMemberPermissions, ...genesisMemberPermissions,
[threadPermissions.LEAVE_THREAD]: true, [threadPermissions.LEAVE_THREAD]: true,
[threadPermissions.CREATE_SIDEBARS]: true, [threadPermissions.CREATE_SIDEBARS]: true,
[threadPermissions.ADD_MEMBERS]: true,
[openChildJoinThread]: true, [openChildJoinThread]: true,
[openChildAddMembers]: true,
}; };
let memberPermissions; let memberPermissions;
if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) { if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) {
memberPermissions = baseMemberPermissions; memberPermissions = baseMemberPermissions;
} else if (threadType === threadTypes.GENESIS) { } else if (threadType === threadTypes.GENESIS) {
memberPermissions = genesisMemberPermissions; memberPermissions = genesisMemberPermissions;
} else { } else {
▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/process-dm-ops.js

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines
function getRolePermissionBlobsForCommunity( function getRolePermissionBlobsForCommunity(
threadType: ThreadType, threadType: ThreadType,
): RolePermissionBlobs { ): RolePermissionBlobs {
const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF; const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF;
const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE; const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE;
const openTopLevelDescendantJoinThread = const openTopLevelDescendantJoinThread =
OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD; OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD;
const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD; const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD;
const openChildAddMembers = OPEN_CHILD + threadPermissions.ADD_MEMBERS;
const genesisMemberPermissions = { const genesisMemberPermissions = {
[threadPermissions.KNOW_OF]: true, [threadPermissions.KNOW_OF]: true,
[threadPermissions.VISIBLE]: true, [threadPermissions.VISIBLE]: true,
[openDescendantKnowOf]: true, [openDescendantKnowOf]: true,
[openDescendantVisible]: true, [openDescendantVisible]: true,
[openTopLevelDescendantJoinThread]: true, [openTopLevelDescendantJoinThread]: true,
}; };
const baseMemberPermissions = { const baseMemberPermissions = {
...genesisMemberPermissions, ...genesisMemberPermissions,
[threadPermissions.LEAVE_THREAD]: true, [threadPermissions.LEAVE_THREAD]: true,
[threadPermissions.CREATE_SIDEBARS]: true, [threadPermissions.CREATE_SIDEBARS]: true,
[threadPermissions.ADD_MEMBERS]: true,
[openChildJoinThread]: true, [openChildJoinThread]: true,
[openChildAddMembers]: true,
}; };
let memberPermissions; let memberPermissions;
if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) { if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) {
memberPermissions = baseMemberPermissions; memberPermissions = baseMemberPermissions;
} else if (threadType === threadTypes.GENESIS) { } else if (threadType === threadTypes.GENESIS) {
memberPermissions = genesisMemberPermissions; memberPermissions = genesisMemberPermissions;
} else { } else {
▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines
function getRolePermissionBlobsForCommunity( function getRolePermissionBlobsForCommunity(
threadType: ThreadType, threadType: ThreadType,
): RolePermissionBlobs { ): RolePermissionBlobs {
const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF; const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF;
const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE; const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE;
const openTopLevelDescendantJoinThread = const openTopLevelDescendantJoinThread =
OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD; OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD;
const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD; const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD;
const openChildAddMembers = OPEN_CHILD + threadPermissions.ADD_MEMBERS;
const genesisMemberPermissions = { const genesisMemberPermissions = {
[threadPermissions.KNOW_OF]: true, [threadPermissions.KNOW_OF]: true,
[threadPermissions.VISIBLE]: true, [threadPermissions.VISIBLE]: true,
[openDescendantKnowOf]: true, [openDescendantKnowOf]: true,
[openDescendantVisible]: true, [openDescendantVisible]: true,
[openTopLevelDescendantJoinThread]: true, [openTopLevelDescendantJoinThread]: true,
}; };
const baseMemberPermissions = { const baseMemberPermissions = {
...genesisMemberPermissions, ...genesisMemberPermissions,
[threadPermissions.LEAVE_THREAD]: true, [threadPermissions.LEAVE_THREAD]: true,
[threadPermissions.CREATE_SIDEBARS]: true, [threadPermissions.CREATE_SIDEBARS]: true,
[threadPermissions.ADD_MEMBERS]: true,
[openChildJoinThread]: true, [openChildJoinThread]: true,
[openChildAddMembers]: true,
}; };
let memberPermissions; let memberPermissions;
if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) { if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) {
memberPermissions = baseMemberPermissions; memberPermissions = baseMemberPermissions;
} else if (threadType === threadTypes.GENESIS) { } else if (threadType === threadTypes.GENESIS) {
memberPermissions = genesisMemberPermissions; memberPermissions = genesisMemberPermissions;
} else { } else {
▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines
View Options

web/app.react.js

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines
function getRolePermissionBlobsForCommunity( function getRolePermissionBlobsForCommunity(
threadType: ThreadType, threadType: ThreadType,
): RolePermissionBlobs { ): RolePermissionBlobs {
const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF; const openDescendantKnowOf = OPEN_DESCENDANT + threadPermissions.KNOW_OF;
const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE; const openDescendantVisible = OPEN_DESCENDANT + threadPermissions.VISIBLE;
const openTopLevelDescendantJoinThread = const openTopLevelDescendantJoinThread =
OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD; OPEN_TOP_LEVEL_DESCENDANT + threadPermissions.JOIN_THREAD;
const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD; const openChildJoinThread = OPEN_CHILD + threadPermissions.JOIN_THREAD;
const openChildAddMembers = OPEN_CHILD + threadPermissions.ADD_MEMBERS;
const genesisMemberPermissions = { const genesisMemberPermissions = {
[threadPermissions.KNOW_OF]: true, [threadPermissions.KNOW_OF]: true,
[threadPermissions.VISIBLE]: true, [threadPermissions.VISIBLE]: true,
[openDescendantKnowOf]: true, [openDescendantKnowOf]: true,
[openDescendantVisible]: true, [openDescendantVisible]: true,
[openTopLevelDescendantJoinThread]: true, [openTopLevelDescendantJoinThread]: true,
}; };
const baseMemberPermissions = { const baseMemberPermissions = {
...genesisMemberPermissions, ...genesisMemberPermissions,
[threadPermissions.LEAVE_THREAD]: true, [threadPermissions.LEAVE_THREAD]: true,
[threadPermissions.CREATE_SIDEBARS]: true, [threadPermissions.CREATE_SIDEBARS]: true,
[threadPermissions.ADD_MEMBERS]: true,
[openChildJoinThread]: true, [openChildJoinThread]: true,
[openChildAddMembers]: true,
}; };
let memberPermissions; let memberPermissions;
if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) { if (threadType === threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT) {
memberPermissions = baseMemberPermissions; memberPermissions = baseMemberPermissions;
} else if (threadType === threadTypes.GENESIS) { } else if (threadType === threadTypes.GENESIS) {
memberPermissions = genesisMemberPermissions; memberPermissions = genesisMemberPermissions;
} else { } else {
▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines