Page MenuHomePhabricator
Differential D14299

[native] Migrate state in FullScreenViewModal to functional component
ClosedPublic
Actions

Authored by angelika on Feb 6 2025, 5:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 1:56 PM
Unknown Object (File)
Wed, Apr 16, 11:14 AM
Unknown Object (File)
Wed, Apr 16, 6:31 AM
Unknown Object (File)
Wed, Apr 16, 3:55 AM
Unknown Object (File)
Tue, Apr 15, 10:27 PM
Unknown Object (File)
Tue, Apr 15, 10:20 PM
Unknown Object (File)
Tue, Apr 15, 10:17 AM
Unknown Object (File)
Mar 18 2025, 6:27 PM
View All 52 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component
Summary

https://linear.app/comm/issue/ENG-8150/convert-fullscreenviewmodal-to-reanimated-2-syntax

Depends on D14298

Test Plan

Verify close and action buttons work correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Feb 6 2025, 5:02 PM
angelika held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 6 2025, 5:02 PM
angelika added a child revision: D14300: [native] Migrate gestures to react-native-gesture-handler v2 API in FullScreenViewModal.Feb 6 2025, 5:05 PM
Harbormaster completed remote builds in B33414: Diff 46943.Feb 6 2025, 5:21 PM
angelika updated this revision to Diff 47077.Feb 12 2025, 8:50 PM

Rebase & bugfixes

angelika published this revision for review.Feb 12 2025, 9:04 PM
Harbormaster completed remote builds in B33493: Diff 47077.Feb 12 2025, 9:12 PM
tomek accepted this revision.Feb 13 2025, 10:29 AM
tomek added inline comments.
native/components/full-screen-view-modal.react.js
1244

We should prefer Array type

This revision is now accepted and ready to land.Feb 13 2025, 10:29 AM
angelika updated this revision to Diff 47181.Feb 20 2025, 2:11 PM

Rebase & bugfixes

angelika added inline comments.Feb 20 2025, 2:39 PM
native/components/full-screen-view-modal.react.js
1244

This was just copied from the original code and the [number] argument will be replaced with number argument in https://phab.comm.dev/D14304 anyway

angelika updated this revision to Diff 47215.Feb 24 2025, 3:50 AM

Rebase

Harbormaster completed remote builds in B33595: Diff 47215.Feb 24 2025, 4:19 AM
Closed by commit rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component (authored by angelika). · Explain WhyFeb 25 2025, 2:48 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component.

Revision Contents
Changeset List

PathSize
native/
components/
61 lines

Diff 47077

View Options

native/components/full-screen-view-modal.react.js

Loading...