Page MenuHomePhabricator
Differential D14460

[identity] Verify prekeys in RefreshUserPrekeys RPC
ClosedPublic
Actions

Authored by bartek on Tue, Mar 18, 2:17 AM.
Tags
None
Referenced Files
F5026735: D14460.id.diff
Mon, Mar 24, 5:35 PM
F5026379: D14460.diff
Mon, Mar 24, 1:34 PM
Unknown Object (File)
Mon, Mar 24, 5:25 AM
Unknown Object (File)
Sun, Mar 23, 10:43 AM
Unknown Object (File)
Sun, Mar 23, 5:34 AM
Unknown Object (File)
Sun, Mar 23, 3:07 AM
Unknown Object (File)
Fri, Mar 21, 11:07 PM
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMM42d533bb18be: [identity] Verify prekeys in RefreshUserPrekeys RPC
Summary
  • Adds prekey signature verification in RefreshUserPrekeys RPC (ENG-10381)
  • Some helper APIs to get notif signing public key

Depends on D14459

Test Plan

Commtest fails without D14459 which introduced valid signatures

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Tue, Mar 18, 2:17 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Mar 18, 2:17 AM
Harbormaster completed remote builds in B33754: Diff 47444.Tue, Mar 18, 2:35 AM
bartek published this revision for review.Tue, Mar 18, 2:50 AM
kamil accepted this revision.Tue, Mar 18, 3:13 AM

It might be good to test it on staging before publishing it to prod:

  • trigger PrekeysHandler to test client
  • trigger cron job on keyserver

A test both correct and malformed keys

This revision is now accepted and ready to land.Tue, Mar 18, 3:13 AM
bartek added a comment.Tue, Mar 18, 7:05 AM
In D14460#401548, @kamil wrote:

It might be good to test it on staging before publishing it to prod:

  • trigger PrekeysHandler to test client
  • trigger cron job on keyserver

A test both correct and malformed keys

Good idea, I'll deploy to staging and do that

Closed by commit rCOMM42d533bb18be: [identity] Verify prekeys in RefreshUserPrekeys RPC (authored by bartek). · Explain WhyTue, Mar 18, 7:07 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM42d533bb18be: [identity] Verify prekeys in RefreshUserPrekeys RPC.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
1 line
4 lines
database/
11 lines
grpc_services/
47 lines

Diff 47452

View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

services/identity/src/database/device_list.rs

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_services/authenticated.rs

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines