Page MenuHomePhabricator
Differential D14460

[identity] Verify prekeys in RefreshUserPrekeys RPC
ClosedPublic
Actions

Authored by bartek on Tue, Mar 18, 2:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 1:55 AM
Unknown Object (File)
Sat, Mar 29, 6:11 PM
Unknown Object (File)
Sat, Mar 29, 2:02 PM
Unknown Object (File)
Fri, Mar 28, 1:16 PM
Unknown Object (File)
Fri, Mar 28, 12:24 PM
Unknown Object (File)
Fri, Mar 28, 7:35 AM
Unknown Object (File)
Thu, Mar 27, 4:03 PM
Unknown Object (File)
Thu, Mar 27, 2:38 PM
View All 17 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMM42d533bb18be: [identity] Verify prekeys in RefreshUserPrekeys RPC
Summary
  • Adds prekey signature verification in RefreshUserPrekeys RPC (ENG-10381)
  • Some helper APIs to get notif signing public key

Depends on D14459

Test Plan

Commtest fails without D14459 which introduced valid signatures

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Tue, Mar 18, 2:17 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Mar 18, 2:17 AM
Harbormaster completed remote builds in B33754: Diff 47444.Tue, Mar 18, 2:35 AM
bartek published this revision for review.Tue, Mar 18, 2:50 AM
kamil accepted this revision.Tue, Mar 18, 3:13 AM

It might be good to test it on staging before publishing it to prod:

  • trigger PrekeysHandler to test client
  • trigger cron job on keyserver

A test both correct and malformed keys

This revision is now accepted and ready to land.Tue, Mar 18, 3:13 AM
bartek added a comment.Tue, Mar 18, 7:05 AM
In D14460#401548, @kamil wrote:

It might be good to test it on staging before publishing it to prod:

  • trigger PrekeysHandler to test client
  • trigger cron job on keyserver

A test both correct and malformed keys

Good idea, I'll deploy to staging and do that

Closed by commit rCOMM42d533bb18be: [identity] Verify prekeys in RefreshUserPrekeys RPC (authored by bartek). · Explain WhyTue, Mar 18, 7:07 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM42d533bb18be: [identity] Verify prekeys in RefreshUserPrekeys RPC.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
1 line
4 lines
database/
11 lines
grpc_services/
47 lines

Diff 47444

View Options

services/identity/src/constants.rs

  • This file was added.
// @flow
import type {
StackNavigationEventMap,
StackNavigationState,
StackOptions,
} from '@react-navigation/core';
import * as React from 'react';
import { Text } from 'react-native';
import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
import RegistrationContainer from '../../account/registration/registration-container.react.js';
import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
import PrimaryButton from '../../components/primary-button.react.js';
import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
import {
type NavigationRoute,
type ScreenParamList,
} from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js';
type Props = {
+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
};
function QRAuthNotPrimaryDevice(prop: Props): React.Node {
const { navigation } = prop;
const styles = useStyles(unboundStyles);
const onPressGoBack = React.useCallback(() => {
navigation
.getParent<
ScreenParamList,
'LinkedDevicesBottomSheet',
StackNavigationState,
StackOptions,
StackNavigationEventMap,
RootNavigationProp<'LinkedDevicesBottomSheet'>,
>()
?.goBack();
}, [navigation]);
return (
<RegistrationContainer>
<RegistrationContentContainer>
<Text style={styles.header}>Device not primary</Text>
<Text style={styles.body}>
This mobile device is not your primary device, and cannot be used to
authorize new devices. Please try your other mobile device(s).
</Text>
</RegistrationContentContainer>
<RegistrationButtonContainer>
<PrimaryButton
onPress={onPressGoBack}
label="Go back"
variant="enabled"
/>
</RegistrationButtonContainer>
</RegistrationContainer>
);
}
const unboundStyles = {
header: {
fontSize: 24,
color: 'panelForegroundLabel',
paddingBottom: 16,
},
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
};
export default QRAuthNotPrimaryDevice;
View Options

services/identity/src/database.rs

  • This file was added.
// @flow
import type {
StackNavigationEventMap,
StackNavigationState,
StackOptions,
} from '@react-navigation/core';
import * as React from 'react';
import { Text } from 'react-native';
import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
import RegistrationContainer from '../../account/registration/registration-container.react.js';
import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
import PrimaryButton from '../../components/primary-button.react.js';
import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
import {
type NavigationRoute,
type ScreenParamList,
} from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js';
type Props = {
+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
};
function QRAuthNotPrimaryDevice(prop: Props): React.Node {
const { navigation } = prop;
const styles = useStyles(unboundStyles);
const onPressGoBack = React.useCallback(() => {
navigation
.getParent<
ScreenParamList,
'LinkedDevicesBottomSheet',
StackNavigationState,
StackOptions,
StackNavigationEventMap,
RootNavigationProp<'LinkedDevicesBottomSheet'>,
>()
?.goBack();
}, [navigation]);
return (
<RegistrationContainer>
<RegistrationContentContainer>
<Text style={styles.header}>Device not primary</Text>
<Text style={styles.body}>
This mobile device is not your primary device, and cannot be used to
authorize new devices. Please try your other mobile device(s).
</Text>
</RegistrationContentContainer>
<RegistrationButtonContainer>
<PrimaryButton
onPress={onPressGoBack}
label="Go back"
variant="enabled"
/>
</RegistrationButtonContainer>
</RegistrationContainer>
);
}
const unboundStyles = {
header: {
fontSize: 24,
color: 'panelForegroundLabel',
paddingBottom: 16,
},
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
};
export default QRAuthNotPrimaryDevice;
View Options

services/identity/src/database/device_list.rs

  • This file was added.
// @flow
import type {
StackNavigationEventMap,
StackNavigationState,
StackOptions,
} from '@react-navigation/core';
import * as React from 'react';
import { Text } from 'react-native';
import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
import RegistrationContainer from '../../account/registration/registration-container.react.js';
import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
import PrimaryButton from '../../components/primary-button.react.js';
import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
import {
type NavigationRoute,
type ScreenParamList,
} from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js';
type Props = {
+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
};
function QRAuthNotPrimaryDevice(prop: Props): React.Node {
const { navigation } = prop;
const styles = useStyles(unboundStyles);
const onPressGoBack = React.useCallback(() => {
navigation
.getParent<
ScreenParamList,
'LinkedDevicesBottomSheet',
StackNavigationState,
StackOptions,
StackNavigationEventMap,
RootNavigationProp<'LinkedDevicesBottomSheet'>,
>()
?.goBack();
}, [navigation]);
return (
<RegistrationContainer>
<RegistrationContentContainer>
<Text style={styles.header}>Device not primary</Text>
<Text style={styles.body}>
This mobile device is not your primary device, and cannot be used to
authorize new devices. Please try your other mobile device(s).
</Text>
</RegistrationContentContainer>
<RegistrationButtonContainer>
<PrimaryButton
onPress={onPressGoBack}
label="Go back"
variant="enabled"
/>
</RegistrationButtonContainer>
</RegistrationContainer>
);
}
const unboundStyles = {
header: {
fontSize: 24,
color: 'panelForegroundLabel',
paddingBottom: 16,
},
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
};
export default QRAuthNotPrimaryDevice;
View Options

services/identity/src/grpc_services/authenticated.rs

  • This file was added.
// @flow
import type {
StackNavigationEventMap,
StackNavigationState,
StackOptions,
} from '@react-navigation/core';
import * as React from 'react';
import { Text } from 'react-native';
import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
import RegistrationContainer from '../../account/registration/registration-container.react.js';
import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
import PrimaryButton from '../../components/primary-button.react.js';
import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
import {
type NavigationRoute,
type ScreenParamList,
} from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js';
type Props = {
+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
};
function QRAuthNotPrimaryDevice(prop: Props): React.Node {
const { navigation } = prop;
const styles = useStyles(unboundStyles);
const onPressGoBack = React.useCallback(() => {
navigation
.getParent<
ScreenParamList,
'LinkedDevicesBottomSheet',
StackNavigationState,
StackOptions,
StackNavigationEventMap,
RootNavigationProp<'LinkedDevicesBottomSheet'>,
>()
?.goBack();
}, [navigation]);
return (
<RegistrationContainer>
<RegistrationContentContainer>
<Text style={styles.header}>Device not primary</Text>
<Text style={styles.body}>
This mobile device is not your primary device, and cannot be used to
authorize new devices. Please try your other mobile device(s).
</Text>
</RegistrationContentContainer>
<RegistrationButtonContainer>
<PrimaryButton
onPress={onPressGoBack}
label="Go back"
variant="enabled"
/>
</RegistrationButtonContainer>
</RegistrationContainer>
);
}
const unboundStyles = {
header: {
fontSize: 24,
color: 'panelForegroundLabel',
paddingBottom: 16,
},
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
};
export default QRAuthNotPrimaryDevice;