Paths

Table of Contentst

-
web/shared-worker/worker/
-
shared-worker/
-
worker/
-
worker-crypto.js

[web] clear old Olm session before creating new one
ClosedPublic
Actions

Authored by kamil on Thu, Mar 20, 5:02 AM.

Details

Reviewers

bartek
tomek
ashoat

Commits

rCOMM04a40fae36f0: [web] clear old Olm session before creating new one

Summary

Some context in ENG-10405.

I found this issue using this PR.

Depends on D14482

Test Plan

Used memory is the same after overwriting session

Diff Detail

Repository

rCOMM Comm

Branch

leaks-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Mar 20, 5:02 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Mar 20, 5:02 AM

ashoat added inline comments.Thu, Mar 20, 5:08 AM

web/shared-worker/worker/worker-crypto.js
762	In this case, do we fail to call `.free` for the new `session`, which is discarded?

Harbormaster completed remote builds in B33791: Diff 47495.Thu, Mar 20, 5:33 AM

add missing free()

kamil published this revision for review.Thu, Mar 20, 5:53 AM

kamil added inline comments.

web/shared-worker/worker/worker-crypto.js
762	yes, good catch - updated and I looked through the file to find other throws/early-exits

ashoat accepted this revision.Thu, Mar 20, 5:54 AM

This revision is now accepted and ready to land.Thu, Mar 20, 5:54 AM

Harbormaster completed remote builds in B33797: Diff 47501.Thu, Mar 20, 6:09 AM

Closed by commit rCOMM04a40fae36f0: [web] clear old Olm session before creating new one (authored by kamil). · Explain WhyThu, Mar 20, 6:21 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM04a40fae36f0: [web] clear old Olm session before creating new one.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

worker/

worker-crypto.js

6 lines

Diff 47495

View Options

web/shared-worker/worker/worker-crypto.js

Show First 20 Lines • Show All 535 Lines • ▼ Show 20 Lines	const icons = options.map(option => {
style={styles.bottomSheetIcon}		style={styles.bottomSheetIcon}
/>		/>
);		);
} else if (option.id === 'ens') {		} else if (option.id === 'ens') {
return (		return (
<CommIcon		<CommIcon
name="ethereum-outline"		name="ethereum-outline"
key={option.id}		key={option.id}
size={18}		size={22}
		style={styles.bottomSheetIcon}
		/>
		);
		} else if (option.id === 'farcaster') {
		return (
		<CommIcon
		name="farcaster-outline"
		key={option.id}
		size={22}
style={styles.bottomSheetIcon}		style={styles.bottomSheetIcon}
/>		/>
);		);
} else if (option.id === 'remove') {		} else if (option.id === 'remove') {
return (		return (
<SWMansionIcon		<SWMansionIcon
name="trash-2"		name="trash-2"
key={option.id}		key={option.id}
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

[web] clear old Olm session before creating new oneClosedPublicActions