Paths

Table of Contentst

[web] clear old Olm session before creating new one
ClosedPublic
Actions

Authored by kamil on Mar 20 2025, 12:02 PM.

Details

Reviewers

bartek
tomek
ashoat

Commits

rCOMM04a40fae36f0: [web] clear old Olm session before creating new one

Summary

Some context in ENG-10405.

I found this issue using this PR.

Depends on D14482

Test Plan

Used memory is the same after overwriting session

Diff Detail

Repository

rCOMM Comm

Branch

leaks-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 20 2025, 12:02 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMar 20 2025, 12:02 PM

ashoat added inline comments.Mar 20 2025, 12:08 PM

web/shared-worker/worker/worker-crypto.js
762	In this case, do we fail to call `.free` for the new `session`, which is discarded?

Harbormaster completed remote builds in B33791: Diff 47495.Mar 20 2025, 12:33 PM

add missing free()

kamil published this revision for review.Mar 20 2025, 12:53 PM

kamil added inline comments.

web/shared-worker/worker/worker-crypto.js
762	yes, good catch - updated and I looked through the file to find other throws/early-exits

ashoat accepted this revision.Mar 20 2025, 12:54 PM

This revision is now accepted and ready to land.Mar 20 2025, 12:54 PM

Harbormaster completed remote builds in B33797: Diff 47501.Mar 20 2025, 1:09 PM

Closed by commit rCOMM04a40fae36f0: [web] clear old Olm session before creating new one. · Explain WhyMar 20 2025, 1:21 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM04a40fae36f0: [web] clear old Olm session before creating new one.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

worker/

worker-crypto.js

6 lines

Diff 47495

View Options

web/shared-worker/worker/worker-crypto.js

[web] clear old Olm session before creating new oneClosedPublicActions