Page MenuHomePhabricator
Differential D14483

[web] clear old Olm session before creating new one
ClosedPublic
Actions

Authored by kamil on Mar 20 2025, 5:02 AM.
Tags
None
Referenced Files
F6182236: D14483.diff
Wed, Apr 23, 7:32 AM
Unknown Object (File)
Fri, Apr 18, 5:06 AM
Unknown Object (File)
Wed, Apr 9, 12:30 PM
Unknown Object (File)
Wed, Apr 9, 9:21 AM
Unknown Object (File)
Tue, Apr 8, 3:30 PM
Unknown Object (File)
Sun, Apr 6, 8:31 AM
Unknown Object (File)
Sun, Apr 6, 12:10 AM
Unknown Object (File)
Wed, Apr 2, 10:08 PM
View All 31 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
ashoat
Commits
rCOMM04a40fae36f0: [web] clear old Olm session before creating new one
Summary

Some context in ENG-10405.

I found this issue using this PR.

Depends on D14482

Test Plan

Used memory is the same after overwriting session

Diff Detail

Repository
rCOMM Comm
Branch
logging
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Mar 20 2025, 5:02 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMar 20 2025, 5:02 AM
ashoat added inline comments.Mar 20 2025, 5:08 AM
web/shared-worker/worker/worker-crypto.js
762 ↗(On Diff #47495)

In this case, do we fail to call .free for the new session, which is discarded?

Harbormaster completed remote builds in B33791: Diff 47495.Mar 20 2025, 5:33 AM
kamil updated this revision to Diff 47501.Mar 20 2025, 5:51 AM

add missing free()

kamil published this revision for review.Mar 20 2025, 5:53 AM
kamil added inline comments.
web/shared-worker/worker/worker-crypto.js
762 ↗(On Diff #47495)

yes, good catch - updated and I looked through the file to find other throws/early-exits

ashoat accepted this revision.Mar 20 2025, 5:54 AM
This revision is now accepted and ready to land.Mar 20 2025, 5:54 AM
Harbormaster completed remote builds in B33797: Diff 47501.Mar 20 2025, 6:09 AM
Closed by commit rCOMM04a40fae36f0: [web] clear old Olm session before creating new one (authored by kamil). · Explain WhyMar 20 2025, 6:21 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM04a40fae36f0: [web] clear old Olm session before creating new one.

Revision Contents
Changeset List

PathSize
web/
shared-worker/
worker/
8 lines

Diff 47501

View Options

web/shared-worker/worker/worker-crypto.js

Loading...