Differential D14487

[ci] Update mac runner image in github workflows
ClosedPublic
Actions

Authored by angelika on Fri, Mar 21, 5:09 AM.

Tags

None

Referenced Files

	F5059395: D14487.diff
	Wed, Mar 26, 10:36 AM

	F5057630: D14487.diff
	Wed, Mar 26, 1:03 AM

	F5057017: D14487.id47517.diff
	Tue, Mar 25, 10:36 PM

	F5056786: D14487.diff
	Tue, Mar 25, 10:07 PM

	F5056492: D14487.diff
	Tue, Mar 25, 10:03 PM

	Unknown Object (File)
	Mon, Mar 24, 3:21 PM

	Unknown Object (File)
	Mon, Mar 24, 3:21 PM

	Unknown Object (File)
	Mon, Mar 24, 2:27 AM

View All 11 Files

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMM9828750c0be2: [ci] Update mac runner image in github workflows

Summary

https://linear.app/comm/issue/ENG-10412/apple-sdk-upcoming-minimum-requirement

Apps uploaded to App Store Connect must be built with Xcode 16 or later using an SDK for iOS 18.
So we need to upgrade our CIs to use Xcode 16.
macos-15 runner uses Xcode 16 by default, so upgrading it should solve the problem.

Test Plan

Build the app on my local machine with Xcode 16 (I had it upgraded long ago).
Then land and verify that all github actions passed?
If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?

Diff Detail

Repository

Branch

graszka22/ENG-10412

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Fri, Mar 21, 5:09 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Mar 21, 5:09 AM

Harbormaster completed remote builds in B33807: Diff 47517.Fri, Mar 21, 5:28 AM

angelika requested review of this revision.Fri, Mar 21, 5:28 AM

If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?

I usually do that for more complex changes, but here I don't think it's necessary

This revision is now accepted and ready to land.Fri, Mar 21, 8:31 AM

Closed by commit rCOMM9828750c0be2: [ci] Update mac runner image in github workflows (authored by angelika). · Explain WhyWed, Mar 26, 5:52 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM9828750c0be2: [ci] Update mac runner image in github workflows.

Revision Contents
Changeset List

Path

Size

.github/

workflows/

2 lines

android_release.yml

2 lines

2 lines

ios_release.yml

2 lines

2 lines

Diff 47517

.github/workflows/android_ci.yml

This file was added.

				.container {
				display: flex;
				column-gap: 8px;
				align-items: center;
				justify-content: center;
				}

.github/workflows/android_release.yml

This file was added.

				.container {
				display: flex;
				column-gap: 8px;
				align-items: center;
				justify-content: center;
				}

.github/workflows/ios_ci.yml

This file was added.

				.container {
				display: flex;
				column-gap: 8px;
				align-items: center;
				justify-content: center;
				}

.github/workflows/ios_release.yml

This file was added.

				.container {
				display: flex;
				column-gap: 8px;
				align-items: center;
				justify-content: center;
				}

.github/workflows/macos_ci.yml

Loading...