Page MenuHomePhabricator
Differential D14487

[ci] Update mac runner image in github workflows
ClosedPublic
Actions

Authored by angelika on Fri, Mar 21, 5:09 AM.
Tags
None
Referenced Files
F5109678: D14487.id47561.diff
Tue, Apr 1, 8:11 PM
Unknown Object (File)
Mon, Mar 31, 12:37 PM
Unknown Object (File)
Sat, Mar 29, 4:45 PM
Unknown Object (File)
Fri, Mar 28, 5:47 AM
Unknown Object (File)
Thu, Mar 27, 12:54 PM
Unknown Object (File)
Wed, Mar 26, 7:59 PM
Unknown Object (File)
Wed, Mar 26, 1:39 PM
Unknown Object (File)
Wed, Mar 26, 10:36 AM
View All 18 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM9828750c0be2: [ci] Update mac runner image in github workflows
Summary

https://linear.app/comm/issue/ENG-10412/apple-sdk-upcoming-minimum-requirement

Apps uploaded to App Store Connect must be built with Xcode 16 or later using an SDK for iOS 18.
So we need to upgrade our CIs to use Xcode 16.
macos-15 runner uses Xcode 16 by default, so upgrading it should solve the problem.

Test Plan

Build the app on my local machine with Xcode 16 (I had it upgraded long ago).
Then land and verify that all github actions passed?
If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Fri, Mar 21, 5:09 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Mar 21, 5:09 AM
Harbormaster completed remote builds in B33807: Diff 47517.Fri, Mar 21, 5:28 AM
angelika requested review of this revision.Fri, Mar 21, 5:28 AM
bartek accepted this revision.Fri, Mar 21, 8:31 AM

If we want to be sure that it works before landing we can try making a PR to gh and run actions on the PR?

I usually do that for more complex changes, but here I don't think it's necessary

This revision is now accepted and ready to land.Fri, Mar 21, 8:31 AM
Closed by commit rCOMM9828750c0be2: [ci] Update mac runner image in github workflows (authored by angelika). · Explain WhyWed, Mar 26, 5:52 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM9828750c0be2: [ci] Update mac runner image in github workflows.
ashoat mentioned this in rCOMM06968dfa4d9d: [native] Fix "hermes contains bitcode" error.Thu, Mar 27, 9:41 PM

Revision Contents
Changeset List

PathSize
.github/
workflows/
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 47561

View Options

.github/workflows/android_ci.yml

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

.github/workflows/android_release.yml

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

.github/workflows/ios_ci.yml

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

.github/workflows/ios_release.yml

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

.github/workflows/macos_ci.yml

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines