Paths

Table of Contentst

Differential D14618

[native] Make CryptoModule::verifySignature accept OlmBuffer message
ClosedPublic
Actions

Authored by bartek on Apr 29 2025, 1:30 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMM1a9b49f0b07d: [native] Make CryptoModule::verifySignature accept OlmBuffer message

Summary

Modified the function to accept any vector of bytes, not only strings (and thus removed the cast to uint8_t*).

Test Plan

Checked that commCoreModule.verifySignature() called from JS still correctly verifies string messages.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 29 2025, 1:30 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 29 2025, 1:30 PM

bartek added a child revision: D14619: [native] Move prekey c++ helpers to separate files.Apr 29 2025, 1:32 PM

Harbormaster completed remote builds in B34043: Diff 47890.Apr 29 2025, 1:49 PM

bartek published this revision for review.Apr 29 2025, 2:28 PM

bartek added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2076–2077 ↗	(On Diff #47890)	Conversion of `std::string` to `std::vector<uint8_t>` (typedefed as `OlmBuffer`) is straightforward because `string.length()` and iteration on strings are char/byte-wise.

kamil accepted this revision.Apr 29 2025, 2:37 PM

This revision is now accepted and ready to land.Apr 29 2025, 2:37 PM

Closed by commit rCOMM1a9b49f0b07d: [native] Make CryptoModule::verifySignature accept OlmBuffer message. · Explain WhyApr 29 2025, 2:49 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM1a9b49f0b07d: [native] Make CryptoModule::verifySignature accept OlmBuffer message.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

2 lines

CryptoModule.cpp

8 lines

NativeModules/

CommCoreModule.cpp

4 lines

Diff 47900

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

Loading...

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...