[native] Move prekey c++ helpers to separate files
ClosedPublic
Actions

Authored by bartek on Apr 29 2025, 1:32 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM7a6551bb4339: [native] Move prekey c++ helpers to separate files

Summary

Moved prekey utils from CommCoreModule to separate OlmUtils.h/cpp because the prekey func will be used in other places too.
Used Claude to make the changes.

Depends on D14618

Test Plan

iOS and Android builds.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 29 2025, 1:32 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 29 2025, 1:32 PM

bartek added a child revision: D14620: [native] Add c++ util to parse ed25519 key from JSON blob.Apr 29 2025, 1:34 PM

Move OTK func back because JSI lib would have to be included in the tools-specific CMake project and it's not worth

bartek retitled this revision from [native] Move prekey/otk c++ helpers to separate files to [native] Move prekey c++ helpers to separate files.Apr 29 2025, 1:59 PM

bartek edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B34044: Diff 47891!Apr 29 2025, 2:06 PM

Harbormaster completed remote builds in B34047: Diff 47894.Apr 29 2025, 2:21 PM

bartek published this revision for review.Apr 29 2025, 2:28 PM

kamil accepted this revision.Apr 29 2025, 2:39 PM

This revision is now accepted and ready to land.Apr 29 2025, 2:39 PM

Closed by commit rCOMM7a6551bb4339: [native] Move prekey c++ helpers to separate files. · Explain WhyApr 29 2025, 2:49 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7a6551bb4339: [native] Move prekey c++ helpers to separate files.