[web][native] convert `MessageEntity` to struct
ClosedPublic
Actions

Authored by kamil on May 8 2025, 4:08 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM2bbbef11ea6b: [web][native] convert `MessageEntity` to struct

Summary

ENG-5719.

We want to use it on the web too and finally remove MessageWithMedias, but Emscripten does not support std::pair - the easiest way to fix that is to just change it to a struct.

Depends on D14667

Test Plan

Build app on native and play with messages and medias - send some, try to load older.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 8 2025, 4:08 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 8 2025, 4:08 PM

kamil added a child revision: D14669: [web] deprecate using `*MessageWeb` methods and use shared implementation with native.May 8 2025, 4:15 PM

Harbormaster failed remote builds in B34114: Diff 47987!May 8 2025, 4:36 PM

rebase

Harbormaster completed remote builds in B34120: Diff 47993.May 8 2025, 6:24 PM

kamil published this revision for review.May 9 2025, 10:03 AM

kamil edited the summary of this revision. (Show Details)

bartek accepted this revision.May 13 2025, 6:50 AM

bartek added inline comments.

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageOperationsUtilities.cpp
50–60 ↗	(On Diff #47993)	I was thinking about creating some constructor/initializer-list-like util to create this entity, but I realized this manual and verbose way is clean and has no significant performance drawbacks