[lib][web][native] update `ReplaceThreadOperation` to decide if data should be included backup
ClosedPublic
Actions

Authored by kamil on Jun 9 2025, 3:51 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM46cd2d6195e5: [lib][web][native] update `ReplaceThreadOperation` to decide if data should be…

Summary

ENG-10842.

Depends on D14823

Test Plan

It's really hard to test everything here; for now, only Flow. In the final diff of the stack, I am going to do some more testing by testing core functionalities of threads and messages (including local and media messages).

Diff Detail

Repository

rCOMM Comm

Branch

land

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 9 2025, 3:51 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 9 2025, 3:51 PM

kamil added inline comments.Jun 9 2025, 3:52 PM

lib/ops/create-replace-thread-operation.js
1 ↗	(On Diff #48460)	I had to create separate file because of import cycle

kamil added a child revision: D14825: [lib][web][native] update `ReplaceThreadActivityEntryOperation` to decide if data should be included backup.Jun 9 2025, 4:05 PM

Harbormaster completed remote builds in B34385: Diff 48460.Jun 9 2025, 4:10 PM

kamil published this revision for review.Jun 10 2025, 8:42 AM

tomek accepted this revision.Jun 11 2025, 12:46 PM

tomek added inline comments.

lib/ops/thread-store-ops.js
44 ↗	(On Diff #48460)	Can't we keep the previous approach?
native/redux/persist.js
492–496 ↗	(On Diff #48460)	For someone reading this comment in the future, it won't be obvious what `this` refers to.