Details

Reviewers

kamil
bartek

Commits

rCOMM9ebf27189e05: [lib] Create a Farcaster message signer

Summary

Create a script that is executed inside a WebView. Create a bundled version of this script and inject it into the WebView.

Test Plan

Provide a nonce and a mnemonic, call Farcaster auth endpoint with the result, and check if a token is returned.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

native/.babelrc.cjs
18 ↗	(On Diff #48644)	This allows importing `.raw` files as a plaintext
native/farcaster-auth/dist/farcaster-signer.bundle.js.raw
1 ↗	(On Diff #48644)	We're generating this file only once. We should never need to update it.
native/farcaster-auth/farcaster-signer.js
6 ↗	(On Diff #48644)	This is the script that is injected into a WebView. But before we can inject it, we have to bundle it with all the necessary dependencies.

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 7 2025, 1:03 PM

Fix ESLint

native/package.json
25 ↗	(On Diff #48645)	If we have to generate the bundle again, this is a command that allows us to do so

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 7 2025, 2:34 PM

Introduce Flow declaration for a .raw file

tomek requested review of this revision.Jul 8 2025, 11:33 AM

Nice work on this

native/farcaster-auth/farcaster-auth-context-provider.react.js
71–79 ↗	(On Diff #48649)	Can't this be defined at the top of the file to avoid calling `useMemo`?
84 ↗	(On Diff #48649)	Maybe reject with meaningful message in this case?
86–98 ↗	(On Diff #48649)	This formatting is really strange, can we make the lines max. 80 chars using `+` operator? Ideally create some util function for this like in SIWE case
native/package.json
25 ↗	(On Diff #48645)	What I see in the code is using `yarn webpack`, is there any difference here? Curious, if there is a good way to make sure it is regenerated, e.g. after `viem` update, but probably nothing other than adding CI job like in case of Emscripten

This revision is now accepted and ready to land.Jul 8 2025, 1:03 PM

native/farcaster-auth/dist/farcaster-signer.bundle.js.raw
1 ↗	(On Diff #48649)	Do we really need to commit this to the repo? If we really feel strongly it needs to be committed, then I think we need some sort CI job to make sure it's up-to-date (apologies if that's already handled in the stack). Otherwise, I suspect it would be better to have a build script for this that makes sure it's always up-to-date when it's deployed.

Create a CI job, improve error handling and fix formatting.

native/farcaster-auth/dist/farcaster-signer.bundle.js.raw
1 ↗	(On Diff #48649)	We could avoid committing it, but it could be inconvenient (e.g., generate the files during `yarn dev`). The main downside is that the repo won't build just after the checkout. Alternatively, we could generate during postinstall, but this also has some downsides - if we change the sources, the bundle won't generate automatically. This can be fixed by watching the files... so overall, we can improve it, but the complexity would increase significantly. For now, a reasonable tradeoff is to introduce a CI job that verifies the consistency.