[lib] Add qrAuthInProgress prop to secondary auth context
ClosedPublic
Actions

Authored by bartek on Jul 11 2025, 7:43 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMc6ae0b5688ef: [lib] Add qrAuthInProgress prop to secondary auth context

Summary

Modified qrAuthFinished boolean to distinguish 3 states: not_started, started and finished. This allows to visually track QR auth as shown in this video.

Test Plan

qrAuthFinished behavior is unchanged
Tested flow shown on the video - progress there is based on the new qrAuthInProgress prop

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 11 2025, 7:43 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 11 2025, 7:43 AM

Harbormaster failed remote builds in B34530: Diff 48689!Jul 11 2025, 7:57 AM

Rebase

bartek published this revision for review.Jul 11 2025, 8:44 AM

Harbormaster completed remote builds in B34532: Diff 48691.Jul 11 2025, 8:49 AM

bartek added a child revision: D14920: [web] Add UI for tracking restoration progress.Jul 11 2025, 9:58 AM

kamil accepted this revision.Jul 15 2025, 4:04 PM

This revision is now accepted and ready to land.Jul 15 2025, 4:04 PM

Closed by commit rCOMMc6ae0b5688ef: [lib] Add qrAuthInProgress prop to secondary auth context. · Explain WhyJul 16 2025, 9:53 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc6ae0b5688ef: [lib] Add qrAuthInProgress prop to secondary auth context.

Revision Contents
Changeset List

Path

Size

lib/

components/

secondary-device-qr-auth-context-provider.react.js

15 lines

Diff 48738

View Options

lib/components/secondary-device-qr-auth-context-provider.react.js

[lib] Add qrAuthInProgress prop to secondary auth contextClosedPublicActions