After connecting or disconnecting, send a message to all the other devices about new connection status.
https://linear.app/comm/issue/ENG-10903/inform-all-the-users-devices-about-the-successful-connection
Depends on D14984
Details
Details
Log in on two devices - at least one physical (so that the Farcaster app can be used). Open the Farcaster section in the profile on the simulator and notice how it changes when performing operations on the physical device. On the physical device connect Farcaster, connect DCs, and disconnect - the result should be reflected on the simulator.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/components/farcaster-data-handler.react.js | ||
|---|---|---|
| 220 | As an improvement, we can consider replacing this call by including the FID and token status in the login response. Then, updating this value is already handled in this diff. | |
Comment Actions
I'm wondering if sending this as Olm-encrypted message would make sense, but I guess not. This message type is not different from e.g. "device list updated" message.
| lib/types/tunnelbroker/peer-to-peer-message-types.js | ||
|---|---|---|
| 131 | The case for BadDeviceToken should do it this way too. | |
| lib/utils/farcaster-utils.js | ||
| 178–180 | Perhaps instead of calling the map() with each render, you could unwrap peer.deviceID in the for loop below | |
| 184–188 | To guarantee type safety, you could do this or define this as a separate variable const rawMessage. | |
| 185 | ||
Comment Actions
Spoke to @tomek about this offline, we're going to make this message encrypted if it's easy