[lib] Refetch peer device list when device keys are missing
ClosedPublic
Actions

Authored by bartek on Jul 25 2025, 9:34 AM.

Details

Reviewers

kamil

Commits

rCOMM05197cb4aea9: [lib] Refetch peer device list when device keys are missing

Summary

Part of ENG-10718.

Depends on D15140

Test Plan

Force-logged out one of devices on Identity, without updating device list. Then called createOlmSessionsWithUser() for that user. Verified that device list was refetched after one of the sessions couldn't be created (deviceKeysMissing = true).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 25 2025, 9:34 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2025, 9:34 AM

Harbormaster completed remote builds in B34985: Diff 49192.Jul 25 2025, 9:52 AM

bartek added a child revision: D15142: [lib][native][web] Support updating deviceID in resetOutboundP2PMessagesForDevice.Jul 25 2025, 10:37 AM

bartek published this revision for review.Jul 25 2025, 10:42 AM

kamil accepted this revision.Jul 28 2025, 9:15 AM

kamil added inline comments.

lib/components/peer-olm-session-creator-provider.react.js
80 ↗	(On Diff #49192)	Shouldn't we await here?

This revision is now accepted and ready to land.Jul 28 2025, 9:15 AM

bartek added inline comments.Jul 28 2025, 1:30 PM

lib/components/peer-olm-session-creator-provider.react.js
80 ↗	(On Diff #49192)	It's not necessary. After refetching, this code is triggered for the second time. Awaiting wouldn't be beneficial at this point, we'd have to call `createOlmSessionsWithUser()` again