Paths

Table of Contentst

Differential D15142

[lib][native][web] Support updating deviceID in resetOutboundP2PMessagesForDevice
ClosedPublic
Actions

Authored by bartek on Jul 25 2025, 10:37 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM79771b824459: [lib][native][web] Support updating deviceID in…

Summary

Depends on D15141

Test Plan

Everything runs and compiles. Logic tested in the next diff

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 25 2025, 10:37 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2025, 10:37 AM

bartek added a child revision: D15143: [lib] Resend P2P messages when primary device changes.Jul 25 2025, 10:39 AM

Harbormaster failed remote builds in B34991: Diff 49198!Jul 25 2025, 10:58 AM

Fix test

Harbormaster failed remote builds in B35009: Diff 49222!Jul 28 2025, 8:48 AM

kamil added inline comments.Jul 28 2025, 9:27 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1459–1464 ↗	(On Diff #49222)	I would use named parameters (`:deviceID`) to make it more readable
web/shared-worker/queries/outbound-p2p-message-queries.test.js
214–217 ↗	(On Diff #49222)	I would implement one test case to cover that, with AI this should be couple minutes and will for sure make testing easier

Add test, use named params

bartek published this revision for review.Jul 28 2025, 12:23 PM

Harbormaster completed remote builds in B35013: Diff 49227.Jul 28 2025, 12:54 PM

kamil accepted this revision.Jul 28 2025, 12:58 PM

This revision is now accepted and ready to land.Jul 28 2025, 12:58 PM

Closed by commit rCOMM79771b824459: [lib][native][web] Support updating deviceID in…. · Explain WhyJul 28 2025, 1:30 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM79771b824459: [lib][native][web] Support updating deviceID in….

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

1 line

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

5 lines

SQLiteQueryExecutor.h

5 lines

SQLiteQueryExecutor.cpp

63 lines

NativeModules/

CommCoreModule.h

3 lines

CommCoreModule.cpp

10 lines

_generated/

commJSI-generated.cpp

schema/

CommCoreModuleSchema.js

1 line

web/

database/

2 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

outbound-p2p-message-queries.test.js

89 lines

types/

sqlite-query-executor.js

5 lines

types/

worker-types.js

1 line

Diff 49235

lib/types/sqlite-types.js

Loading...

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/schema/CommCoreModuleSchema.js

Loading...

web/database/sqlite-api.js

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...

web/types/worker-types.js

Loading...