Paths

Table of Contentst

Differential D15178

[tunnelbroker] refactor AMPQ code from `WebsocketSession` to a separate module
ClosedPublic
Actions

Authored by kamil on Aug 8 2025, 8:43 AM.

Details

Reviewers

bartek

Commits

rCOMMf7ecdc7a8e21: [tunnelbroker] refactor AMPQ code from `WebsocketSession` to a separate module

Summary

ENG-10869.

Cleaning up mixed responsibilities in WebsocketSession, as we need to add Farcaster here, and it could get too messy.

Most of the code is just copy-paste

Depends on D15177

Test Plan

commtest

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 8 2025, 8:43 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 8 2025, 8:44 AM

kamil added a child revision: D15179: [tunnelbroker] refactor notif code from `WebsocketSession` to a separate module.Aug 8 2025, 8:45 AM

Harbormaster completed remote builds in B35062: Diff 49313.Aug 8 2025, 9:01 AM

kamil published this revision for review.Aug 8 2025, 12:01 PM

bartek accepted this revision.Aug 11 2025, 9:46 AM

This revision is now accepted and ready to land.Aug 11 2025, 9:46 AM

Closed by commit rCOMMf7ecdc7a8e21: [tunnelbroker] refactor AMPQ code from `WebsocketSession` to a separate module. · Explain WhyAug 11 2025, 11:38 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf7ecdc7a8e21: [tunnelbroker] refactor AMPQ code from `WebsocketSession` to a separate module.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

amqp.rs

	amqp_client/

amqp.rs

amqp_client/

mod.rs

249 lines

grpc/

mod.rs

2 lines

main.rs

3 lines

websockets/

mod.rs

2 lines

session.rs

248 lines

shared/

tunnelbroker_messages/

src/

messages/

session.rs

2 lines

Diff 49504

View Options

services/tunnelbroker/src/amqp.rs

View Options

services/tunnelbroker/src/amqp_client/amqp.rs

View Options

services/tunnelbroker/src/amqp_client/mod.rs

View Options

services/tunnelbroker/src/grpc/mod.rs

View Options

services/tunnelbroker/src/main.rs

View Options

services/tunnelbroker/src/websockets/mod.rs

View Options

services/tunnelbroker/src/websockets/session.rs

View Options

shared/tunnelbroker_messages/src/messages/session.rs

[tunnelbroker] refactor AMPQ code from `WebsocketSession` to a separate moduleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49504

services/tunnelbroker/src/amqp.rs

services/tunnelbroker/src/amqp_client/amqp.rs

services/tunnelbroker/src/amqp_client/mod.rs

services/tunnelbroker/src/grpc/mod.rs

services/tunnelbroker/src/main.rs

services/tunnelbroker/src/websockets/mod.rs

services/tunnelbroker/src/websockets/session.rs

shared/tunnelbroker_messages/src/messages/session.rs

[tunnelbroker] refactor AMPQ code from `WebsocketSession` to a separate module
ClosedPublic
Actions

Revision Contents
Changeset List