Create a new text message based on a thread type and send it to Farcaster.
Depends on D15225
Details
Details
Check if creating a text message works both in group and 1:1 conversations by sending a message on Comm and checking if it appears on Farcaster.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/id-utils.js | ||
|---|---|---|
| 141–149 ↗ | (On Diff #49622) | We need to move these in order to avoid a circular import |
| lib/shared/threads/protocols/farcaster-thread-protocol.js | ||
|---|---|---|
| 61–82 ↗ | (On Diff #49622) | Note: this API currently only works for 1:1 conversations, and group conversations where a sender is an admin https://linear.app/comm/issue/ENG-11125/prepare-putdirectcastv3-api#comment-23b768fd |
Comment Actions
I would test retries too, but I recall when testing it that it worked fine
| lib/shared/id-utils.js | ||
|---|---|---|
| 141–149 ↗ | (On Diff #49622) | I would move all regexes like this to a separate file to keep them together |
| lib/shared/id-utils.js | ||
|---|---|---|
| 141–149 ↗ | (On Diff #49622) | Makes sense, but at this point, all the regexes are in the same place. We could consider moving all of them to a separate place, but maybe in the future. In this diff, only functions converting IDs are moved - and I guess the new place is even better than the original one. |