Differential D15233

[native] Fix JNI exception messages on Android
ClosedPublic
Actions

Authored by bartek on Aug 25 2025, 12:33 PM.

Tags

None

Referenced Files

	F32068123: D15233.1764997218.diff
	Fri, Dec 5, 5:00 AM

Subscribers

Details

Reviewers

Commits

rCOMM5c6159d7085a: [native] Fix JNI exception messages on Android

Summary

Depends on D15190

Test Plan

Confirmed that a proper error message with stacktrace is now displayed, example:

java.lang.RuntimeException: Java exception: app.comm.android.aescrypto.DecryptionFailedException: AES Decryption failed
	at app.comm.android.aescrypto.AESCryptoModuleCompat$Companion.decrypt(AESCryptoModule.kt:174)
	at app.comm.android.aescrypto.AESCryptoModuleCompat.decrypt(Unknown Source:2)
	at com.facebook.jni.ThreadScopeSupport.runStdFunctionImpl(Native Method)
	at com.facebook.jni.ThreadScopeSupport.runStdFunction(ThreadScopeSupport.java:32)

	at com.facebook.jni.ThreadScopeSupport.runStdFunctionImpl(Native Method)
	at com.facebook.jni.ThreadScopeSupport.runStdFunction(ThreadScopeSupport.java:32)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 25 2025, 12:33 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 25 2025, 12:33 PM

Harbormaster failed remote builds in B35533: Diff 50008!Aug 25 2025, 12:35 PM

bartek added a child revision: D15234: [native] Treat UserKeys decryption failure as invalid credentials.Aug 25 2025, 12:37 PM

bartek published this revision for review.Aug 25 2025, 12:52 PM

angelika accepted this revision.Aug 26 2025, 9:46 AM

This revision is now accepted and ready to land.Aug 26 2025, 9:46 AM

This revision was landed with ongoing or failed builds.Aug 28 2025, 6:24 AM

Closed by commit rCOMM5c6159d7085a: [native] Fix JNI exception messages on Android. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5c6159d7085a: [native] Fix JNI exception messages on Android.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

cpp/

9 lines

Diff 50046

native/android/app/src/cpp/jniHelpers.h

Loading...