[lib] avoid viewer changing its own role in Farcaster threads
ClosedPublic
Actions

Authored by kamil on Sep 4 2025, 12:46 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM6bf84cdc836c: [lib] avoid viewer changing its own role in Farcaster threads

Summary

ENG-11214.

Depends on D15291

Test Plan

There is no option to change own role, tested on web and native

Diff Detail

Repository

rCOMM Comm

Branch

threads

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Sep 4 2025, 12:46 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 4 2025, 12:46 PM

kamil published this revision for review.Sep 4 2025, 12:47 PM

Harbormaster completed remote builds in B35630: Diff 50160.Sep 4 2025, 1:05 PM

kamil added a child revision: D15293: [lib][web][native] extract removing thread members to protocol.Sep 4 2025, 1:24 PM

bartek accepted this revision.Sep 4 2025, 4:53 PM

This revision is now accepted and ready to land.Sep 4 2025, 4:53 PM

Closed by commit rCOMM6bf84cdc836c: [lib] avoid viewer changing its own role in Farcaster threads. · Explain WhySep 5 2025, 9:12 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6bf84cdc836c: [lib] avoid viewer changing its own role in Farcaster threads.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

6 lines

threads/

protocols/

dm-thread-protocol.js

1 line

farcaster-thread-protocol.js

1 line

keyserver-thread-protocol.js

1 line

thread-spec.js

1 line

Diff 50160

View Options

lib/shared/thread-utils.js

View Options

lib/shared/threads/protocols/dm-thread-protocol.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/protocols/keyserver-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

[lib] avoid viewer changing its own role in Farcaster threadsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50160

lib/shared/thread-utils.js

lib/shared/threads/protocols/dm-thread-protocol.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/protocols/keyserver-thread-protocol.js

lib/shared/threads/thread-spec.js

[lib] avoid viewer changing its own role in Farcaster threads
ClosedPublic
Actions

Revision Contents
Changeset List