Page MenuHomePhabricator
Differential D3109

[web] last message thread font size to match figma
ClosedPublic
Actions

Authored by • benschac on Feb 4 2022, 1:26 PM.
Tags
None
Referenced Files
F3307538: D3109.diff
Tue, Nov 19, 2:41 AM
Unknown Object (File)
Sat, Nov 16, 10:19 PM
Unknown Object (File)
Fri, Nov 8, 9:18 AM
Unknown Object (File)
Fri, Nov 8, 8:50 AM
Unknown Object (File)
Sat, Nov 2, 4:01 AM
Unknown Object (File)
Mon, Oct 21, 1:58 AM
Unknown Object (File)
Mon, Oct 21, 1:58 AM
Unknown Object (File)
Oct 18 2024, 3:19 AM
View All 100 Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMe484c6cf3710: [web] last message thread font size to match figma
Summary

font was 16px when it should have been 14. https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A78356

Image 2022-02-04 at 4.26.52 PM.jpg (572×804 px, 60 KB)

Test Plan

should look like figma

Diff Detail

Repository
rCOMM Comm
Branch
fix-unread (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Feb 4 2022, 1:26 PM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 4 2022, 1:26 PM
• benschac edited the summary of this revision. (Show Details)Feb 4 2022, 1:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2022, 1:35 PM
Harbormaster failed remote builds in B6558: Diff 9303!
• benschac requested review of this revision.Feb 4 2022, 7:56 PM
ashoat added a comment.Feb 5 2022, 1:38 PM

Each message preview should be limited to one line of text. Any idea why some previews are taking multiple lines in the screenshot?

atul accepted this revision.Feb 7 2022, 6:08 AM

Accepting to unblock on assumption that this diff is just about font-size and singleline vs multiline issue will be addressed in a separate diff.

This revision is now accepted and ready to land.Feb 7 2022, 6:08 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 7 2022, 6:08 AM
This revision now requires review to proceed.Feb 7 2022, 6:08 AM
ashoat accepted this revision.Feb 7 2022, 7:05 PM
This revision is now accepted and ready to land.Feb 7 2022, 7:05 PM
• benschac added a comment.Feb 9 2022, 7:18 AM
In D3109#82250, @atul wrote:

Accepting to unblock on assumption that this diff is just about font-size and singleline vs multiline issue will be addressed in a separate diff.

yes. Will address in another diff.

This revision was landed with ongoing or failed builds.Feb 9 2022, 7:20 AM
Closed by commit rCOMMe484c6cf3710: [web] last message thread font size to match figma (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMe484c6cf3710: [web] last message thread font size to match figma.

Revision Contents
Changeset List

PathSize
web/
chat/
1 line

Diff 9303

View Options

web/chat/chat-thread-list.css

Loading...