[web] last message thread font size to match figma
ClosedPublic
Actions

Authored by • benschac on Feb 4 2022, 1:26 PM.

Details

Reviewers

atul
ashoat

Commits

rCOMMe484c6cf3710: [web] last message thread font size to match figma

Summary

font was 16px when it should have been 14. https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A78356

Image 2022-02-04 at 4.26.52 PM.jpg (572×804 px, 60 KB)

Test Plan

should look like figma

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• benschac created this revision.Feb 4 2022, 1:26 PM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 4 2022, 1:26 PM

• benschac edited the summary of this revision. (Show Details)Feb 4 2022, 1:27 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2022, 1:35 PM

Harbormaster failed remote builds in B6558: Diff 9303!

• benschac requested review of this revision.Feb 4 2022, 7:56 PM

Each message preview should be limited to one line of text. Any idea why some previews are taking multiple lines in the screenshot?

Accepting to unblock on assumption that this diff is just about font-size and singleline vs multiline issue will be addressed in a separate diff.

This revision is now accepted and ready to land.Feb 7 2022, 6:08 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 7 2022, 6:08 AM

This revision now requires review to proceed.Feb 7 2022, 6:08 AM

ashoat accepted this revision.Feb 7 2022, 7:05 PM

This revision is now accepted and ready to land.Feb 7 2022, 7:05 PM

In D3109#82250, @atul wrote:

Accepting to unblock on assumption that this diff is just about font-size and singleline vs multiline issue will be addressed in a separate diff.

yes. Will address in another diff.

This revision was landed with ongoing or failed builds.Feb 9 2022, 7:20 AM

Closed by commit rCOMMe484c6cf3710: [web] last message thread font size to match figma (authored by • benschac). · Explain Why

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMe484c6cf3710: [web] last message thread font size to match figma.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-list.css

1 line

Diff 9460

View Options

web/chat/chat-thread-list.css

[web] last message thread font size to match figmaClosedPublicActions